From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinclair Yeh Subject: Re: [PATCH 2/5] drm: vmwgfx: constify pci_device_id. Date: Mon, 17 Jul 2017 23:55:54 -0700 Message-ID: <20170718065535.GA5669@ubuntu> References: <1500102893-23353-1-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1500102893-23353-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Arvind Yadav Cc: airlied@linux.ie, linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org, thellstrom@vmware.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Thanks. Queued. On Sat, Jul 15, 2017 at 12:44:53PM +0530, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 13765 800 20 14585 38f9 gpu/drm/vmwgfx/vmwgfx_drv.o > > File size After adding 'const': > text data bss dec hex filename > 13829 736 20 14585 38f9 gpu/drm/vmwgfx/vmwgfx_drv.o > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 4a64155..f5fe28f 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -227,7 +227,7 @@ static const struct drm_ioctl_desc vmw_ioctls[] = { > DRM_AUTH | DRM_RENDER_ALLOW), > }; > > -static struct pci_device_id vmw_pci_id_list[] = { > +static const struct pci_device_id vmw_pci_id_list[] = { > {0x15ad, 0x0405, PCI_ANY_ID, PCI_ANY_ID, 0, 0, VMWGFX_CHIP_SVGAII}, > {0, 0, 0} > }; > -- > 2.7.4 >