All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jacob von Chorus <jacobvonchorus@cwphoto.ca>
Cc: Insop Song <insop.song@gainspeed.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH v2 1/2] staging: gs_fpgaboot: add buffer overflow checks
Date: Tue, 18 Jul 2017 09:00:01 +0200	[thread overview]
Message-ID: <20170718070001.GA5255@kroah.com> (raw)
In-Reply-To: <20170718004726.17227-1-jacobvonchorus@cwphoto.ca>

On Mon, Jul 17, 2017 at 08:47:25PM -0400, Jacob von Chorus wrote:
> Four fields in struct fpgaimage are char arrays of length MAX_STR (256).
> The amount of data read into these buffers is controlled by a length
> field in the bitstream file read from userspace. If a corrupt or
> malicious firmware file was supplied, kernel data beyond these buffers
> can be overwritten arbitrarily.
> 
> This patch adds a check of the bitstream's length value to ensure it
> fits within the bounds of the allocated buffers. An error condition is
> returned from gs_read_bitstream if any of the reads fail.
> 
> Signed-off-by: Jacob von Chorus <jacobvonchorus@cwphoto.ca>
> ---
>  drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 48 ++++++++++++++++++++++++-------
>  1 file changed, 37 insertions(+), 11 deletions(-)

What changed from v1?  Always list that below the --- line.

Please fix up and resend...

thanks,

greg k-h

  parent reply	other threads:[~2017-07-18  7:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  0:47 [PATCH v2 1/2] staging: gs_fpgaboot: add buffer overflow checks Jacob von Chorus
2017-07-18  0:47 ` [PATCH v2 2/2] staging: gs_fpgaboot: change char to u8 Jacob von Chorus
2017-07-18  1:22   ` Joe Perches
2017-07-18  1:56     ` Jacob von Chorus
2017-07-18  7:00 ` Greg Kroah-Hartman [this message]
2017-07-18  9:15 ` [PATCH v2 1/2] staging: gs_fpgaboot: add buffer overflow checks Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718070001.GA5255@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=insop.song@gainspeed.com \
    --cc=jacobvonchorus@cwphoto.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.