Re: [Drbd-dev] [PATCH] drbd: sort file list

[Roland Kammerer <roland.kammerer@linbit.com>]

On Mon, Jul 17, 2017 at 09:29:30PM +0200, Bernhard M. Wiedemann wrote:
> because it influences the ordering of entries in compat.h
> which influences srcversion= checksum

"srcversion" is for in tree drbd.

> which prevents drbd.ko from building reproducibly.
> 
> See https://reproducible-builds.org/ for why this matters.
> ---
>  drbd/Kbuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drbd/Kbuild b/drbd/Kbuild
> index 2d1b4d0..c5787a6 100644
> --- a/drbd/Kbuild
> +++ b/drbd/Kbuild
> @@ -70,7 +70,7 @@ COMPAT_FORCE := FORCE
>  endif
>  
>  ifneq ($(KBUILD_STAGE),modpost)
> -TEST_C := $(wildcard $(src)/drbd-kernel-compat/tests/*.c)
> +TEST_C := $(sort $(wildcard $(src)/drbd-kernel-compat/tests/*.c))
>  TEST_R := $(TEST_C:$(src)/drbd-kernel-compat/tests/%.c=$(obj)/.compat_test.%.result)
>  $(obj)/.compat_test.%.result: $(src)/drbd-kernel-compat/tests/%.c $(COMPAT_FORCE)
>  	$(call cmd,compat_test_result)

which is for out of tree drbd, like the whole compat checks and compat.h.

so what are you actually talking about?

Regards, rck