From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:50362 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbdGRI7y (ORCPT ); Tue, 18 Jul 2017 04:59:54 -0400 Date: Tue, 18 Jul 2017 16:59:40 +0800 From: Ming Lei To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche , Konrad Rzeszutek Wilk , Boris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/6] xen-blkfront: quiesce/unquiesce queue instead of start/stop queues Message-ID: <20170718085936.GA14364@ming.t460p> References: <20170714231601.14444-1-ming.lei@redhat.com> <20170714231601.14444-2-ming.lei@redhat.com> <20170717112056.ysdtuugo5ipayv7e@MacBook-Pro-de-Roger.local> <20170717150621.GB26571@ming.t460p> <20170717160227.x5cmghxgqgyx2ye6@dhcp-3-128.uk.xensource.com> <20170718005316.GA3660@ming.t460p> <20170718074018.a52oya6fl3vyqerg@dhcp-3-128.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20170718074018.a52oya6fl3vyqerg@dhcp-3-128.uk.xensource.com> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Tue, Jul 18, 2017 at 08:40:18AM +0100, Roger Pau Monn� wrote: > On Tue, Jul 18, 2017 at 08:53:28AM +0800, Ming Lei wrote: > > On Mon, Jul 17, 2017 at 05:02:27PM +0100, Roger Pau Monn� wrote: > > > On Mon, Jul 17, 2017 at 11:06:28PM +0800, Ming Lei wrote: > > > > On Mon, Jul 17, 2017 at 12:20:56PM +0100, Roger Pau Monn� wrote: > > > > > seems fairly easy to mess up and call "start" on a "quiesced" queue > > > > > (or the other way around). > > > > > > > > Definitely it shouldn't be worried because start/stop is removed > > > > in this patchset. > > > > > > Hm, how is that? I haven't seen any patch to blkfront to remove the > > > usage of start/stop, am I missing something? > > > > http://secure-web.cisco.com/19iIG2bc3Ce2_t8mSF4YQ2LopepIvjAOqnPAXQ_QahSNOEvLBmechzNZ0pQOPfSRhy3hyC4t6L-JJzu81FvWRyLoBmhtq7F9uEk7XZsTt-XNxLN1KdEJvEeUAWelYSd9NthbvpGad6DmpJ0QCHSOgq4mRcDaqlz5mRmNkTvxls-ri1qCqy6am0jTDdraGINb_BUyV0894BtaFOMGJGEKLjcrBfFfT6C5XHSEdsiuB12ZLIUyaRVyU0TCUz6Sm4uhD/http%3A%2F%2Fmarc.info%2F%3Fl%3Dlinux-block%26m%3D150007418321196%26w%3D2 > > Sadly I have not been CCed or otherwise I've lost patch #5. Related to > that patch AFAICT kick_pending_request_queues can be removed, since > it's only used by one caller (or it can even be removed in this patch, > #1). There are two callers: blkfront_connect() and blkif_restart_queue(). -- Ming