Re: [Qemu-devel] [PATCH] hmp: allow cpu index for "info lapic"

[<wang.yi59@zte.com.cn>]

Hi David,


Thanks a lot for your review and suggestion, I will resend a new version right now.

>* Yi Wang (wang.yi59@zte.com.cn) wrote:

>> Add [vcpu index] support for hmp command "info lapic", which is

>> useful when debugging ipi and so on.

>> 

>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>

>> Signed-off-by: Yun Liu <liu.yunh@zte.com.cn>

>> ---

>>  hmp-commands-info.hx  | 6 +++---

>>  target/i386/monitor.c | 7 ++++++-

>>  2 files changed, 9 insertions(+), 4 deletions(-)

>> 

>> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx

>> index 07500ef..8ad2f81 100644

>> --- a/hmp-commands-info.hx

>> +++ b/hmp-commands-info.hx

>> @@ -115,9 +115,9 @@ ETEXI

>>  #if defined(TARGET_I386)

>>      {

>>          .name       = "lapic",

>> -        .args_type  = "",

>> -        .params     = "",

>> -        .help       = "show local apic state",

>> +        .args_type  = "vcpu:i?",

>> +        .params     = "[vcpu index]",

>> +        .help       = "show local apic state (default vcpu 0)",

>

>Normally I think the syntax for the help is 

>(vcpu: vCPU to read, default is 0)"





---

Best wishes

Yi Wang