Re: [Qemu-devel] Hacks for building on gcc 7 / Fedora 26

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, Jul 18, 2017 at 07:35:58AM -0500, Eric Blake wrote:
> On 07/18/2017 02:23 AM, Daniel P. Berrange wrote:
> >> How would it not help?  Are we using gcc 7 on windows builds?  Adding
> >> the assert is enough to shut up new gcc; old gcc was already silent; and
> >> if mingw is still on old gcc, it doesn't matter whether assert() is
> >> marked noreturn for what this patch is doing.
> > 
> > Mingw isn't using a fork of GCC anymore, its all mainline. Thus Fedora's
> > mingw gcc packages track native gcc packages. IOW i686-w64-mingw32-gcc
> > is already on version 7.1.0 in Fedora
> 
> So I guess that means running 'make docker-test-mingw@fedora' on Fedora
> 26 will find out if we need further tweaks?  Trying it now...
> 
> Nope, didn't get very far :(
> 
> $ make docker-test-mingw@fedora
>   BUILD   fedora
> make[1]: Entering directory '/home/eblake/qemu'
>   ARCHIVE qemu.tgz
> usage: git archive [<options>] <tree-ish> [<path>...]
> ...
> make[1]: *** [/home/eblake/qemu/tests/docker/Makefile.include:35:
> docker-src.2017-07-18-07.35.20.4101] Error 129
> make[1]: Leaving directory '/home/eblake/qemu'
> make: *** [/home/eblake/qemu/tests/docker/Makefile.include:156:
> docker-run-test-mingw@fedora] Error 2
> 
> Am I not doing it right?

That works fine for me - perhaps  V=1 will tell you what's wrong
with the git archive command.

In any case, despite having gcc 7.1.0, I don't see the error
messages in question when running a mingw build. It could be that
the new problems GCC 7 reports are only triggered when combined
with a suitable C library like GCC, to get the symbols annotated
to enable fortify source to check them.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|