From: Vinod Koul <vinod.koul@intel.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: dan.j.williams@intel.com, dave.jiang@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ioat: constify pci_device_id.
Date: Tue, 18 Jul 2017 21:32:33 +0530 [thread overview]
Message-ID: <20170718160232.GU3053@localhost> (raw)
In-Reply-To: <c4b3ad48a6804f63eb9e8de6383a4b6793a09a18.1500307589.git.arvind.yadav.cs@gmail.com>
On Mon, Jul 17, 2017 at 09:39:00PM +0530, Arvind Yadav wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 12582 3056 16 15654 3d26 drivers/dma/ioat/init.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 14773 865 16 15654 3d26 drivers/dma/ioat/init.o
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2017-07-18 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 16:09 [PATCH] dmaengine: ioat: constify pci_device_id Arvind Yadav
2017-07-18 16:02 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718160232.GU3053@localhost \
--to=vinod.koul@intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.