From: Logan Gunthorpe <logang@deltatee.com>
To: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Stephen Bates <sbates@raithlin.com>,
Serge Semin <fancer.lancer@gmail.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH v2 07/16] ntb: ntb_test: ensure the link is up before trying to configure the mws
Date: Tue, 18 Jul 2017 10:04:00 -0600 [thread overview]
Message-ID: <20170718160409.6493-8-logang@deltatee.com> (raw)
In-Reply-To: <20170718160409.6493-1-logang@deltatee.com>
After the link tests, there is a race on one side of the test for
the link coming up. It's possible, in some cases, for the test script
to write to the 'peer_trans' files before the link has come up.
To fix this, we simply use the link event file to ensure both sides
see the link as up before continuning.
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
---
tools/testing/selftests/ntb/ntb_test.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index 1c12b5855e4f..5fc7ad359e21 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -333,6 +333,10 @@ function ntb_tool_tests()
link_test $LOCAL_TOOL $REMOTE_TOOL
link_test $REMOTE_TOOL $LOCAL_TOOL
+ #Ensure the link is up on both sides before continuing
+ write_file Y $LOCAL_TOOL/link_event
+ write_file Y $REMOTE_TOOL/link_event
+
for PEER_TRANS in $(ls $LOCAL_TOOL/peer_trans*); do
PT=$(basename $PEER_TRANS)
write_file $MW_SIZE $LOCAL_TOOL/$PT
--
2.11.0
next prev parent reply other threads:[~2017-07-18 16:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 16:03 [PATCH v2 00/16] Switchtec NTB Support Logan Gunthorpe
2017-07-18 16:03 ` [PATCH v2 01/16] switchtec: move structure definitions into a common header Logan Gunthorpe
2017-07-18 16:03 ` [PATCH v2 02/16] switchtec: export class symbol for use in upper layer driver Logan Gunthorpe
2017-07-18 16:03 ` [PATCH v2 03/16] switchtec: add NTB hardware register definitions Logan Gunthorpe
2017-07-18 16:03 ` [PATCH v2 04/16] switchtec: add link event notifier callback Logan Gunthorpe
2017-07-18 16:03 ` [PATCH v2 05/16] ntb: ensure ntb_mw_get_align() is only called when the link is up Logan Gunthorpe
2017-07-18 16:03 ` [PATCH v2 06/16] ntb: add check and comment for link up to mw_count() and mw_get_align() Logan Gunthorpe
2017-07-18 16:04 ` Logan Gunthorpe [this message]
2017-07-18 16:04 ` [PATCH v2 08/16] switchtec_ntb: introduce initial NTB driver Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 09/16] switchtec_ntb: initialize hardware for memory windows Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 10/16] switchtec_ntb: initialize hardware for doorbells and messages Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 11/16] switchtec_ntb: add skeleton NTB driver Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 12/16] switchtec_ntb: add link management Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 13/16] switchtec_ntb: implement doorbell registers Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 14/16] switchtec_ntb: implement scratchpad registers Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 15/16] switchtec_ntb: add memory window support Logan Gunthorpe
2017-07-18 16:04 ` [PATCH v2 16/16] switchtec_ntb: update switchtec documentation with notes for NTB Logan Gunthorpe
2017-07-18 17:51 ` [PATCH v2 00/16] Switchtec NTB Support Allen Hubbe
2017-07-18 17:51 ` Allen Hubbe
2017-07-18 17:51 ` Allen Hubbe
2017-07-18 18:08 ` Logan Gunthorpe
2017-11-10 11:27 ` cruisethai
2017-11-11 2:52 ` lsgunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718160409.6493-8-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.