All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme/pci: Fix HMB size calculation
Date: Tue, 18 Jul 2017 19:39:54 +0200	[thread overview]
Message-ID: <20170718173954.GA7511@lst.de> (raw)
In-Reply-To: <1500335139-6338-1-git-send-email-keith.busch@intel.com>

On Mon, Jul 17, 2017@07:45:39PM -0400, Keith Busch wrote:
> It's possible the preferred HMB size may not be a multiple of the
> chunk_size. This patch will set the chunk_size to the descriptor's actual
> length so the last iteration doesn't cause the total size to exceed the
> allocated HMB size.

This looks a little weird, and might do the wrong thing
if we hit the retry loop after reducing chunk_size.

I suspect we just need to change to

	for (size = 0; size < preferred; size += len) {

and move len to function scope.

  parent reply	other threads:[~2017-07-18 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 23:45 [PATCH] nvme/pci: Fix HMB size calculation Keith Busch
2017-07-17 23:47 ` Keith Busch
2017-07-18 17:39 ` Christoph Hellwig [this message]
2017-07-18 18:04   ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718173954.GA7511@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.