diff for duplicates of <20170718182003.00004555@huawei.com> diff --git a/a/1.txt b/N1/1.txt index cf5fd51..9753ff4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,44 +1,40 @@ On Mon, 17 Jul 2017 21:44:19 +0000 -"Br=FCns, Stefan" <Stefan.Bruens@rwth-aachen.de> wrote: +"Brüns, Stefan" <Stefan.Bruens@rwth-aachen.de> wrote: > On Montag, 17. Juli 2017 22:53:57 CEST Jonathan Cameron wrote: > > On Mon, 17 Jul 2017 01:34:10 +0200 -> >=20 -> > Stefan Br=FCns <stefan.bruens@rwth-aachen.de> wrote: =20 -> > > The ina2xx driver appeared in the Linux kernel version 4.5, but provi= -ded -> > > no documentation. Contrary to other uses of resistance in IIO, ina2xx= - uses +> > +> > Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: +> > > The ina2xx driver appeared in the Linux kernel version 4.5, but provided +> > > no documentation. Contrary to other uses of resistance in IIO, ina2xx uses > > > microohms instead of ohms in the sysfs attribute. -> > >=20 -> > > Signed-off-by: Stefan Br=FCns <stefan.bruens@rwth-aachen.de> =20 -> >=20 +> > > +> > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> +> > > > This has me confused. The documentation is already -> > there and lists it as being in ohms. =20 ->=20 -> Which obviously, from reading the source code, is wrong - it uses microoh= -ms. +> > there and lists it as being in ohms. +> +> Which obviously, from reading the source code, is wrong - it uses microohms. Hmm. Not good ->=20 +> > Also, the current Description contains IMHO irrelevant stuff: > "The value of the shunt resistor may be known only at runtime fom an > eeprom content read by a client application." ->=20 +> > > Ah, subtle filename difference. Docs in are -> > Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc =20 ->=20 +> > Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc +> > Well spotted ... ->=20 +> > > This attribute effectively exists for other parts -> > as well now. =20 ->=20 -> My grep foo failed me here, the only parts I could find are the MAX9611 (= -which=20 +> > as well now. +> +> My grep foo failed me here, the only parts I could find are the MAX9611 (which > specifies and uses ohms) and the INA2xx. ->=20 -> adc/qcom-spmi-iadc.c allows to read the RSENSE value from device tree=20 +> +> adc/qcom-spmi-iadc.c allows to read the RSENSE value from device tree > (specified in microohms), but does not expose it via sysfs. ->=20 +> > Can you point me to other devices? You found it - just the one other part be it with several different shunt related entries. @@ -50,14 +46,11 @@ attempt to try and be consistent with hwmon (we rapidly ran into issues generalizing but by then were were stuck with a few odd units). Recent policy has been the basic SI units if at all possible. ->=20 -> Slightly off-topic: Some attributes in iio are read from device-tree (e.g= -.=20 -> shunt resistor values), should the iio documentation point to the dt bind= -ings?=20 -> Currently, only mount_matrix in sysfs-bus-iio vaguely mentions device-tre= -e. ->=20 +> +> Slightly off-topic: Some attributes in iio are read from device-tree (e.g. +> shunt resistor values), should the iio documentation point to the dt bindings? +> Currently, only mount_matrix in sysfs-bus-iio vaguely mentions device-tree. +> The ABI docs probably shouldn't as it's an implementation detail. However, if it's particularly useful for some reason I don't see any real problem with doing so. @@ -65,16 +58,15 @@ real problem with doing so. Jonathan > Kind regards, ->=20 +> > Stefan ->=20 +> > > > --- -> > >=20 +> > > > > > Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc | 7 +++++++ > > > 1 file changed, 7 insertions(+) -> > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ina2x= -x-adc -> > >=20 +> > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc +> > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc > > > b/Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc new file mode > > > 100644 @@ -86,12 +78,11 @@ x-adc > > > +Date: December 2015 > > > +KernelVersion: 4.5 > > > +Contact: linux-iio@vger.kernel.org -> > > +Description: The value of the shunt resistor connected to the V_IN+= - =20 +> > > +Description: The value of the shunt resistor connected to the V_IN+ > and > > > V_IN- + inputs, used to compute the current flowing through the shunt -> > > and + the corresponding power. In microohms. =20 ->=20 +> > > and + the corresponding power. In microohms. +> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org diff --git a/a/content_digest b/N1/content_digest index 1176528..e845870 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -16,46 +16,42 @@ "\00:1\0" "b\0" "On Mon, 17 Jul 2017 21:44:19 +0000\n" - "\"Br=FCns, Stefan\" <Stefan.Bruens@rwth-aachen.de> wrote:\n" + "\"Br\303\274ns, Stefan\" <Stefan.Bruens@rwth-aachen.de> wrote:\n" "\n" "> On Montag, 17. Juli 2017 22:53:57 CEST Jonathan Cameron wrote:\n" "> > On Mon, 17 Jul 2017 01:34:10 +0200\n" - "> >=20\n" - "> > Stefan Br=FCns <stefan.bruens@rwth-aachen.de> wrote: =20\n" - "> > > The ina2xx driver appeared in the Linux kernel version 4.5, but provi=\n" - "ded\n" - "> > > no documentation. Contrary to other uses of resistance in IIO, ina2xx=\n" - " uses\n" + "> > \n" + "> > Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de> wrote: \n" + "> > > The ina2xx driver appeared in the Linux kernel version 4.5, but provided\n" + "> > > no documentation. Contrary to other uses of resistance in IIO, ina2xx uses\n" "> > > microohms instead of ohms in the sysfs attribute.\n" - "> > >=20\n" - "> > > Signed-off-by: Stefan Br=FCns <stefan.bruens@rwth-aachen.de> =20\n" - "> >=20\n" + "> > > \n" + "> > > Signed-off-by: Stefan Br\303\274ns <stefan.bruens@rwth-aachen.de> \n" + "> > \n" "> > This has me confused. The documentation is already\n" - "> > there and lists it as being in ohms. =20\n" - ">=20\n" - "> Which obviously, from reading the source code, is wrong - it uses microoh=\n" - "ms.\n" + "> > there and lists it as being in ohms. \n" + "> \n" + "> Which obviously, from reading the source code, is wrong - it uses microohms.\n" "Hmm. Not good\n" - ">=20\n" + "> \n" "> Also, the current Description contains IMHO irrelevant stuff:\n" "> \"The value of the shunt resistor may be known only at runtime fom an\n" "> eeprom content read by a client application.\"\n" - ">=20\n" + "> \n" "> > Ah, subtle filename difference. Docs in are\n" - "> > Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc =20\n" - ">=20\n" + "> > Documentation/ABI/testing/sysfs-bus-iio-ina2xx-adc \n" + "> \n" "> Well spotted ...\n" - ">=20\n" + "> \n" "> > This attribute effectively exists for other parts\n" - "> > as well now. =20\n" - ">=20\n" - "> My grep foo failed me here, the only parts I could find are the MAX9611 (=\n" - "which=20\n" + "> > as well now. \n" + "> \n" + "> My grep foo failed me here, the only parts I could find are the MAX9611 (which \n" "> specifies and uses ohms) and the INA2xx.\n" - ">=20\n" - "> adc/qcom-spmi-iadc.c allows to read the RSENSE value from device tree=20\n" + "> \n" + "> adc/qcom-spmi-iadc.c allows to read the RSENSE value from device tree \n" "> (specified in microohms), but does not expose it via sysfs.\n" - ">=20\n" + "> \n" "> Can you point me to other devices?\n" "You found it - just the one other part be it with several different shunt\n" "related entries.\n" @@ -67,14 +63,11 @@ "generalizing but by then were were stuck with a few odd units).\n" "\n" "Recent policy has been the basic SI units if at all possible.\n" - ">=20\n" - "> Slightly off-topic: Some attributes in iio are read from device-tree (e.g=\n" - ".=20\n" - "> shunt resistor values), should the iio documentation point to the dt bind=\n" - "ings?=20\n" - "> Currently, only mount_matrix in sysfs-bus-iio vaguely mentions device-tre=\n" - "e.\n" - ">=20\n" + "> \n" + "> Slightly off-topic: Some attributes in iio are read from device-tree (e.g. \n" + "> shunt resistor values), should the iio documentation point to the dt bindings? \n" + "> Currently, only mount_matrix in sysfs-bus-iio vaguely mentions device-tree.\n" + "> \n" "The ABI docs probably shouldn't as it's an implementation detail.\n" "However, if it's particularly useful for some reason I don't see any\n" "real problem with doing so.\n" @@ -82,16 +75,15 @@ "Jonathan\n" "\n" "> Kind regards,\n" - ">=20\n" + "> \n" "> Stefan\n" - ">=20\n" + "> \n" "> > > ---\n" - "> > >=20\n" + "> > > \n" "> > > Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc | 7 +++++++\n" "> > > 1 file changed, 7 insertions(+)\n" - "> > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ina2x=\n" - "x-adc\n" - "> > >=20\n" + "> > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc\n" + "> > > \n" "> > > diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc\n" "> > > b/Documentation/ABI/testing/sysfs-bus-iio-adc-ina2xx-adc new file mode\n" "> > > 100644\n" @@ -103,15 +95,14 @@ "> > > +Date:\t\tDecember 2015\n" "> > > +KernelVersion:\t4.5\n" "> > > +Contact:\tlinux-iio@vger.kernel.org\n" - "> > > +Description: \tThe value of the shunt resistor connected to the V_IN+=\n" - " =20\n" + "> > > +Description: \tThe value of the shunt resistor connected to the V_IN+ \n" "> and\n" "> > > V_IN- +\t\tinputs, used to compute the current flowing through the shunt\n" - "> > > and +\t\tthe corresponding power. In microohms. =20\n" - ">=20\n" + "> > > and +\t\tthe corresponding power. In microohms. \n" + "> \n" "> --\n" "> To unsubscribe from this list: send the line \"unsubscribe linux-iio\" in\n" "> the body of a message to majordomo@vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -4216f8d82bb5774172fa0736ff13f05ec9b5f7eebfa9c28068fd961e0b1570d0 +8484d1058f7145dc70bbf07c6cb647ad9915d7902370bc2be9c22030187dddc9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.