From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Date: Tue, 18 Jul 2017 12:20:36 -0700 Message-ID: <20170718192036.GB6173@intel.com> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paul Kocialkowski Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMTgsIDIwMTcgYXQgMDU6MjU6MzZQTSArMDMwMCwgUGF1bCBLb2NpYWxrb3dz a2kgd3JvdGU6Cj4gVGhpcyBhZGRzIHRoZSBjb25uZWN0b3IgbmFtZSB3aGVuIHByaW50aW5nIGEg ZGVidWcgbWVzc2FnZSBhYm91dCB0aGUgRFAKPiBsaW5rIHRyYWluaW5nIHJlc3VsdC4gSXQgaXMg dXNlZnVsIHRvIGZpZ3VyZSBvdXQgd2hhdCBjb25uZWN0b3IgaXMKPiBmYWlsaW5nIHdoZW4gbXVs dGlwbGUgRFAgY29ubmVjdG9ycyBhcmUgdXNlZC4KPgoKVGhhbmtzIGZvciB0aGUgcGF0Y2gsIHRo aXMgZG9lcyBtYWtlIHNlbnNlIGR1cmluZyB0aGUgbGluayB0cmFpbmluZwpmYWlsdXJlIGRlYnVn Z2luZyB0byBrbm93IHRoZSBjb25uZWN0b3IgbmFtZS4KV2hpbGUgYXQgaXQgZmVlbCBmcmVlIHRv IGNoYW5nZSAiRmFpbGVkIiwgIkxpbmsgUmF0ZSwgTGFuZSBDb3VudCIsIHRvIHVwcGVyIGNhc2UK aW4gdGhlIGZhaWx1cmVfaGFuZGxpbmcgY2FzZSB0byBiZSBjb25zaXN0ZW50IHdpdGggdGhlIHBh c3MgY2FzZS4KClJldmlld2VkLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50 ZWwuY29tPgoKTWFuYXNpCgo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgS29jaWFsa293c2tpIDxwYXVs LmtvY2lhbGtvd3NraUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcuYyB8IDggKysrKysrLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jCj4gaW5kZXggYjc5YzFjMGU0MDRjLi4w NTkwN2ZhOGE1NTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBf bGlua190cmFpbmluZy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlu a190cmFpbmluZy5jCj4gQEAgLTMyMSwxMiArMzIxLDE2IEBAIGludGVsX2RwX3N0YXJ0X2xpbmtf dHJhaW4oc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCWlmICghaW50ZWxfZHBfbGlua190 cmFpbmluZ19jaGFubmVsX2VxdWFsaXphdGlvbihpbnRlbF9kcCkpCj4gIAkJZ290byBmYWlsdXJl X2hhbmRsaW5nOwo+ICAKPiAtCURSTV9ERUJVR19LTVMoIkxpbmsgVHJhaW5pbmcgUGFzc2VkIGF0 IExpbmsgUmF0ZSA9ICVkLCBMYW5lIGNvdW50ID0gJWQiLAo+ICsJRFJNX0RFQlVHX0tNUygiW0NP Tk5FQ1RPUjolZDolc10gTGluayBUcmFpbmluZyBQYXNzZWQgYXQgTGluayBSYXRlID0gJWQsIExh bmUgY291bnQgPSAlZCIsCj4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLmJhc2UuaWQs Cj4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLm5hbWUsCj4gIAkJICAgICAgaW50ZWxf ZHAtPmxpbmtfcmF0ZSwgaW50ZWxfZHAtPmxhbmVfY291bnQpOwo+ICAJcmV0dXJuOwo+ICAKPiAg IGZhaWx1cmVfaGFuZGxpbmc6Cj4gLQlEUk1fREVCVUdfS01TKCJMaW5rIFRyYWluaW5nIGZhaWxl ZCBhdCBsaW5rIHJhdGUgPSAlZCwgbGFuZSBjb3VudCA9ICVkIiwKPiArCURSTV9ERUJVR19LTVMo IltDT05ORUNUT1I6JWQ6JXNdIExpbmsgVHJhaW5pbmcgZmFpbGVkIGF0IGxpbmsgcmF0ZSA9ICVk LCBsYW5lIGNvdW50ID0gJWQiLAo+ICsJCSAgICAgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5iYXNl LmlkLAo+ICsJCSAgICAgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5uYW1lLAo+ICAJCSAgICAgIGlu dGVsX2RwLT5saW5rX3JhdGUsIGludGVsX2RwLT5sYW5lX2NvdW50KTsKPiAgCWlmICghaW50ZWxf ZHBfZ2V0X2xpbmtfdHJhaW5fZmFsbGJhY2tfdmFsdWVzKGludGVsX2RwLAo+ICAJCQkJCQkgICAg IGludGVsX2RwLT5saW5rX3JhdGUsCj4gLS0gCj4gMi4xMy4yCj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751530AbdGRTNr (ORCPT ); Tue, 18 Jul 2017 15:13:47 -0400 Received: from mga06.intel.com ([134.134.136.31]:21651 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402AbdGRTNq (ORCPT ); Tue, 18 Jul 2017 15:13:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,378,1496127600"; d="scan'208";a="1152797819" Date: Tue, 18 Jul 2017 12:20:36 -0700 From: Manasi Navare To: Paul Kocialkowski Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , Jani Nikula , David Airlie Subject: Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result Message-ID: <20170718192036.GB6173@intel.com> References: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170718142536.2306-1-paul.kocialkowski@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: > This adds the connector name when printing a debug message about the DP > link training result. It is useful to figure out what connector is > failing when multiple DP connectors are used. > Thanks for the patch, this does make sense during the link training failure debugging to know the connector name. While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case in the failure_handling case to be consistent with the pass case. Reviewed-by: Manasi Navare Manasi > Signed-off-by: Paul Kocialkowski > --- > drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c > index b79c1c0e404c..05907fa8a553 100644 > --- a/drivers/gpu/drm/i915/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c > @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) > if (!intel_dp_link_training_channel_equalization(intel_dp)) > goto failure_handling; > > - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d", > + intel_connector->base.base.id, > + intel_connector->base.name, > intel_dp->link_rate, intel_dp->lane_count); > return; > > failure_handling: > - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d", > + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d", > + intel_connector->base.base.id, > + intel_connector->base.name, > intel_dp->link_rate, intel_dp->lane_count); > if (!intel_dp_get_link_train_fallback_values(intel_dp, > intel_dp->link_rate, > -- > 2.13.2 >