All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/5] refine virtio-net XDP
Date: Tue, 18 Jul 2017 23:13:15 +0300	[thread overview]
Message-ID: <20170718230748-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1500295441-19339-1-git-send-email-jasowang@redhat.com>

On Mon, Jul 17, 2017 at 08:43:56PM +0800, Jason Wang wrote:
> Hi:
> 
> This series brings two optimizations for virtio-net XDP:
> 
> - avoid reset during XDP set
> - turn off offloads on demand

I'm glad to see this take shape - this can be
extended to optimize virtnet_get_headroom so we don't
waste room if adjust_head is enabled.

I see a couple of issues, responded to individual patches.


> Please review.
> 
> Thanks
> 
> Jason Wang (5):
>   virtio_ring: allow to store zero as the ctx
>   virtio-net: pack headroom into ctx for mergeable buffer
>   virtio-net: switch to use new ctx API for small buffer
>   virtio-net: do not reset during XDP set
>   virtio-net: switch off offloads on demand if possible on XDP set
> 
>  drivers/net/virtio_net.c     | 325 +++++++++++++++++++++++++------------------
>  drivers/virtio/virtio_ring.c |   2 +-
>  2 files changed, 194 insertions(+), 133 deletions(-)
> 
> -- 
> 2.7.4

  parent reply	other threads:[~2017-07-18 20:13 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17 12:43 [PATCH net-next 0/5] refine virtio-net XDP Jason Wang
2017-07-17 12:43 ` [PATCH net-next 1/5] virtio_ring: allow to store zero as the ctx Jason Wang
2017-07-17 12:43 ` Jason Wang
2017-07-17 12:43 ` [PATCH net-next 2/5] virtio-net: pack headroom into ctx for mergeable buffer Jason Wang
2017-07-18 18:59   ` Michael S. Tsirkin
2017-07-19  2:29     ` Jason Wang
2017-07-19  2:29     ` Jason Wang
2017-07-18 18:59   ` Michael S. Tsirkin
2017-07-17 12:43 ` [PATCH net-next 3/5] virtio-net: switch to use new ctx API for small buffer Jason Wang
2017-07-17 12:43 ` Jason Wang
2017-07-18 19:20   ` Michael S. Tsirkin
2017-07-19  2:30     ` Jason Wang
2017-07-19  2:30       ` Jason Wang
2017-07-18 19:20   ` Michael S. Tsirkin
2017-07-17 12:44 ` [PATCH net-next 4/5] virtio-net: do not reset during XDP set Jason Wang
2017-07-18 19:49   ` Michael S. Tsirkin
2017-07-19  2:35     ` Jason Wang
2017-07-19  2:35       ` Jason Wang
2017-07-18 19:49   ` Michael S. Tsirkin
2017-07-17 12:44 ` Jason Wang
2017-07-17 12:44 ` [PATCH net-next 5/5] virtio-net: switch off offloads on demand if possible on " Jason Wang
2017-07-17 12:44 ` Jason Wang
2017-07-18 20:07   ` Michael S. Tsirkin
2017-07-18 20:07     ` Michael S. Tsirkin
2017-07-19  2:39     ` Jason Wang
2017-07-24 21:36       ` Michael S. Tsirkin
2017-07-24 21:36         ` Michael S. Tsirkin
2017-07-19  2:39     ` Jason Wang
2017-07-18 18:24 ` [PATCH net-next 0/5] refine virtio-net XDP David Miller
2017-07-18 18:24   ` David Miller
2017-07-18 18:47   ` Michael S. Tsirkin
2017-07-18 18:47     ` Michael S. Tsirkin
2017-07-18 20:13 ` Michael S. Tsirkin [this message]
2017-07-19  2:40   ` Jason Wang
2017-07-19  2:40     ` Jason Wang
2017-07-18 20:13 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2017-07-17 12:43 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718230748-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.