All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: wang.yi59@zte.com.cn
Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com,
	rth@twiddle.net, Liu.Jianjun3@zte.com.cn, liu.yunh@zte.com.cn
Subject: Re: [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic"
Date: Wed, 19 Jul 2017 09:10:29 +0100	[thread overview]
Message-ID: <20170719081028.GA2103@work-vm> (raw)
In-Reply-To: <201707191247531805742@zte.com.cn>

* wang.yi59@zte.com.cn (wang.yi59@zte.com.cn) wrote:
> Hi Eduardo,
> 
> Thank you for your reply!
> 
> >On Mon, Jul 17, 2017 at 09:49:37PM -0400, Yi Wang wrote:
> 
> >> Add [vcpu] index support for hmp command "info lapic", which is
> 
> >> useful when debugging ipi and so on. Current behavior is not
> 
> >> changed when the parameter isn't specified.
> 
> >> 
> 
> >> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> 
> >> Signed-off-by: Yun Liu <liu.yunh@zte.com.cn>
> 
> >
> 
> >We have 8 monitor commands (see below) that use the CPU set by
> >the "cpu" command (mon_get_cpu()) as input.  Why is "info lapic"
> >special?
> 
> When we debugging a problem of ipi, we wanted to verify lapic info
> on each vCPU, but we found that we could only get vCPU 0's lapic
> through "info lapic", so we supposed this patch could help those
> who have the same problem as us.

I think Eduardo's point is that you can already do:
    cpu 0
    info lapic
    cpu 1
    info lapic

Dave
> 
> 
> 
> 
> >
> 
> >* info cpustats
> 
> >* info lapic
> 
> >* info mem
> 
> >* info registers
> 
> >* info tlb
> 
> >* x
> 
> >* memsave
> 
> >* inject-nmi (QMP)
> 
> Monitor command "info registers" already have "-a" parameter to
> 
> show all vCPU's info. -)
> 
> May I send some new patches for the other monitor commands, which may
> 
> be helpful for analyzing multiple cpu problems?
> 
> 
> 
> 
> 
> ---
> 
> Best wishes
> 
> Yi Wang


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  parent reply	other threads:[~2017-07-19  8:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19  4:47 [Qemu-devel] [PATCH v2] hmp: allow cpu index for "info lapic" wang.yi59
2017-07-19  6:16 ` Eduardo Habkost
2017-07-19 12:16   ` Dr. David Alan Gilbert
2017-07-19 12:41     ` Eduardo Habkost
2017-07-19 15:02       ` Eric Blake
2017-07-19 15:07         ` Daniel P. Berrange
2017-07-19 15:17           ` Eric Blake
2017-07-19 18:32             ` Eduardo Habkost
2017-07-19 19:17               ` Dr. David Alan Gilbert
2017-07-19 19:46                 ` Eduardo Habkost
2017-07-19  8:10 ` Dr. David Alan Gilbert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-07-20  4:41 wang.yi59
2017-07-19  8:48 wang.yi59
2017-07-19  9:16 ` Igor Mammedov
2017-07-19  4:25 wang.yi59
2017-07-19  7:36 ` Igor Mammedov
2017-07-18  1:49 Yi Wang
2017-07-18 14:54 ` Igor Mammedov
2017-07-18 23:26   ` Eduardo Habkost
2017-07-19  7:39     ` Igor Mammedov
2017-07-18 23:25 ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170719081028.GA2103@work-vm \
    --to=dgilbert@redhat.com \
    --cc=Liu.Jianjun3@zte.com.cn \
    --cc=ehabkost@redhat.com \
    --cc=liu.yunh@zte.com.cn \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=wang.yi59@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.