Re: [PATCH] MIPS: Octeon: Fix broken EDAC driver.

[Ralf Baechle <ralf@linux-mips.org>]

On Wed, Jul 19, 2017 at 10:39:19AM +0100, James Hogan wrote:
> Date:   Wed, 19 Jul 2017 10:39:19 +0100
> From: James Hogan <james.hogan@imgtec.com>
> To: "Steven J. Hill" <steven.hill@cavium.com>
> CC: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
> Subject: Re: [PATCH] MIPS: Octeon: Fix broken EDAC driver.
> Content-Type: multipart/signed; micalg=pgp-sha256;
>         protocol="application/pgp-signature"; boundary="y2MHPAl/EzyWgzIZ"
> 
> On Wed, May 31, 2017 at 12:20:47PM -0500, Steven J. Hill wrote:
> > From: "Steven J. Hill" <Steven.Hill@cavium.com>
> > 
> > Commit 15f6847 "MIPS: Octeon: Remove unused L2C types and macros."
> 
> Please use 12 nibbles of hash and I think brackets around the subject is
> common style, i.e.
> 
> Commit 15f6847923a8 ("MIPS: Octeon: Remove unused L2C types and
> macros.") broke the EDAC driver...
> 
> > broke the EDAC driver. Bring back 'cvmx-l2d-defs.h' file and the
> > missing types for L2C.
> > 
> 
> Lets add:
> Fixes: 15f6847923a8 ("MIPS: Octeon: Remove unused L2C types and macros.")
> 
> > Signed-off-by: Steven J. Hill <steven.hill@cavium.com>
> 
> I suppose we need this too now that 4.12 is out:
> Cc: <stable@vger.kernel.org> # 4.12+
> 
> (Maybe Ralf can fix that stuff up when applying?)

I think the Cc: to stable is not necessary with the Fixes: tag.

> The patch looks correct based on the definitions removed in the patch it
> fixes, and it does indeed fix the build errors, so:
> 
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
> 
> Though this warning persists:
> 
> drivers/edac/octeon_edac-lmc.c In function ‘octeon_lmc_edac_poll_o2’:
> drivers/edac/octeon_edac-lmc.c:87:24: warning: ‘((long unsigned int*)&int_reg)[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (int_reg.s.sec_err || int_reg.s.ded_err) {

Steven, can you sort this?  Thanks,

  Ralf