From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 4.12 26/84] x86/xen/efi: Initialize only the EFI struct members used by Xen Date: Thu, 20 Jul 2017 10:39:10 +0200 Message-ID: <20170720083910.aygobq7t7g7laszt@gmail.com> References: <20170719092322.362625377@linuxfoundation.org> <20170719092323.396710042@linuxfoundation.org> <20170719103747.GZ4448@olila.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170719103747.GZ4448@olila.local.net-space.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Daniel Kiper Cc: jgross@suse.com, linux-efi@vger.kernel.org, Ard Biesheuvel , Peter Zijlstra , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, matt@codeblueprint.co.uk, andrew.cooper3@citrix.com, xen-devel@lists.xenproject.org, Boris Ostrovsky , Linus Torvalds , Thomas Gleixner List-Id: linux-efi@vger.kernel.org CiogRGFuaWVsIEtpcGVyIDxkYW5pZWwua2lwZXJAb3JhY2xlLmNvbT4gd3JvdGU6Cgo+IEhleSBH cmVnLAo+IAo+IE9uIFdlZCwgSnVsIDE5LCAyMDE3IGF0IDExOjQzOjMyQU0gKzAyMDAsIEdyZWcg S3JvYWgtSGFydG1hbiB3cm90ZToKPiA+IDQuMTItc3RhYmxlIHJldmlldyBwYXRjaC4gIElmIGFu eW9uZSBoYXMgYW55IG9iamVjdGlvbnMsIHBsZWFzZSBsZXQgbWUga25vdy4KPiAKPiBXaHkgZGlk IHlvdSBza2lwIHRoaXMgcGF0Y2ggZm9yIDQuMTE/IElNTyBpdCBzaG91bGQgYmUgYXBwbGllZCB0 aGVyZSB0b28uCgpUaGUgdGhpbmcgaXMsIHRoaXMgcGF0Y2ggc2hvdWxkIHByb2JhbHkgbm90IGV2 ZW4gYmUgaW4gdjQuMTIsIGFzIGl0IHNob3VsZCBvbmx5IAptYWtlIGFueSBkaWZmZXJlbmNlIGlm IHRoZXJlJ3MgYSBzZXBhcmF0ZSBfYnVnXyBpbiB0aGUga2VybmVsLgoKVGhpcyBwYXRjaCBtYWtl cyB0aGluZ3MgbW9yZSByb2J1c3QgZ29pbmcgZm9yd2FyZCwgYnV0IEkgcXVlc3Rpb24gdGhhdCBp dCBuZWVkcyB0byAKYmUgaW4gLXN0YWJsZS4KClRoYW5rcywKCglJbmdvCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935763AbdGTJQS (ORCPT ); Thu, 20 Jul 2017 05:16:18 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38155 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933179AbdGTIjP (ORCPT ); Thu, 20 Jul 2017 04:39:15 -0400 Date: Thu, 20 Jul 2017 10:39:10 +0200 From: Ingo Molnar To: Daniel Kiper Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Boris Ostrovsky , Ard Biesheuvel , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , andrew.cooper3@citrix.com, jgross@suse.com, linux-efi@vger.kernel.org, matt@codeblueprint.co.uk, xen-devel@lists.xenproject.org Subject: Re: [PATCH 4.12 26/84] x86/xen/efi: Initialize only the EFI struct members used by Xen Message-ID: <20170720083910.aygobq7t7g7laszt@gmail.com> References: <20170719092322.362625377@linuxfoundation.org> <20170719092323.396710042@linuxfoundation.org> <20170719103747.GZ4448@olila.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170719103747.GZ4448@olila.local.net-space.pl> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Kiper wrote: > Hey Greg, > > On Wed, Jul 19, 2017 at 11:43:32AM +0200, Greg Kroah-Hartman wrote: > > 4.12-stable review patch. If anyone has any objections, please let me know. > > Why did you skip this patch for 4.11? IMO it should be applied there too. The thing is, this patch should probaly not even be in v4.12, as it should only make any difference if there's a separate _bug_ in the kernel. This patch makes things more robust going forward, but I question that it needs to be in -stable. Thanks, Ingo