All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <marcus.wolf@wolf-entwicklungen.de>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	kbuild-all@01.org, grant.likely@linaro.org
Subject: Re: [PATCH 1/1] drivers/staging/pi433: New driver
Date: Thu, 20 Jul 2017 13:31:50 +0200	[thread overview]
Message-ID: <20170720113150.GA25299@kroah.com> (raw)
In-Reply-To: <652336354.3806.1500549785404@ox.hosteurope.de>

On Thu, Jul 20, 2017 at 01:23:05PM +0200, Marcus Wolf wrote:
> Hi Greg,
> 
> below you can see the report with the error on m68k. It was sent to me from a
> test robot of intel.
> 
> According to my research, this problem occured, because there is no hardware
> support for floating point on the m68k (or it was configured not to use it).
> Therefore gcc uses an internal function, provided by libgcc. Obviously libgcc
> wasn't linked...
> 
> I don't know how to come arround this problem by modifying my code (except
> reducing the accuracy of the calculation by not using floating point).
> 
> Can we ignore the error or can I do something else?
> Maybe a special include just in case of m68k can help??!?
> I don't have an environment for building m68k.

It looks like a 64bit issue, try wrapping your division in that function
with a call to do_div() like you do elsewhere in that function.  That
should solve the issue.

thanks,

greg k-h

  reply	other threads:[~2017-07-20 11:31 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 16:02 Submit of a driver for Pi433 - a radio module for Raspberry Pi Marcus Wolf
2017-07-12  7:43 ` Greg KH
2017-07-15 11:15   ` Marcus Wolf
     [not found]     ` <197075499.65628.1500117344413-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 11:24       ` Greg KH
2017-07-15 11:24         ` Greg KH
2017-07-15 12:26         ` Marcus Wolf
     [not found]         ` <20170715112454.GB1753-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-15 12:59           ` Marcus Wolf
2017-07-15 12:59             ` Marcus Wolf
     [not found]             ` <89433969.66090.1500123565835-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 13:02               ` Greg KH
2017-07-15 13:02                 ` Greg KH
     [not found]                 ` <20170715130220.GA22977-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-15 13:10                   ` Marcus Wolf
2017-07-15 13:10                     ` Marcus Wolf
     [not found]                     ` <826180465.66159.1500124248340-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 13:16                       ` Greg KH
2017-07-15 13:16                         ` Greg KH
2017-07-15 13:40                         ` Marcus Wolf
     [not found]                           ` <1152815224.66246.1500126030682-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 13:47                             ` Greg KH
2017-07-15 13:47                               ` Greg KH
     [not found]                               ` <20170715134739.GA20360-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-15 17:05                                 ` Wolf Entwicklungen
2017-07-15 17:05                                   ` Wolf Entwicklungen
2017-07-16  6:45                                   ` Greg KH
     [not found]                                     ` <20170716064546.GA11484-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-16  9:52                                       ` [PATCH 1/1] drivers/staging/pi433: New driver Wolf Entwicklungen
2017-07-16  9:52                                         ` Wolf Entwicklungen
     [not found]                                         ` <39f4e59cae6d241235f8f2cc6eebb33c-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAheVn4GUFc=-webmailer1-aF9hzfVklKyMhzHtofonGKYwuClDyyMfX55GXzBGTY8@public.gmane.org>
2017-07-16 10:15                                           ` Greg KH
2017-07-16 10:15                                             ` Greg KH
     [not found]                                             ` <20170716101531.GA19773-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-16 13:53                                               ` Marcus Wolf
2017-07-16 13:53                                                 ` Marcus Wolf
2017-07-16 14:47                                                 ` Greg KH
2017-07-16 14:47                                                   ` Greg KH
2017-07-17 13:26                                           ` kbuild test robot
2017-07-17 13:26                                             ` kbuild test robot
     [not found]                                             ` <201707172156.DCyTyWc2%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-07-20 11:23                                               ` Marcus Wolf
2017-07-20 11:23                                                 ` Marcus Wolf
2017-07-20 11:31                                                 ` Greg KH [this message]
2017-07-20 11:37                                                 ` Dan Carpenter
2017-07-20 11:37                                                   ` Dan Carpenter
2017-07-20 12:27                                                   ` Geert Uytterhoeven
2017-07-20 12:27                                                     ` Geert Uytterhoeven
2017-07-20 15:56                                                     ` [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation Marcus Wolf
2017-07-20 15:56                                                       ` Marcus Wolf
     [not found]                                                       ` <255867683.7064.1500566196444-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-29  0:01                                                         ` Greg KH
2017-07-29  0:01                                                           ` Greg KH
     [not found]                                                           ` <20170729000118.GA28861-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-29  8:51                                                             ` Marcus Wolf
2017-07-29  8:51                                                               ` Marcus Wolf
2017-07-29 22:21                                                               ` Greg KH
     [not found]                                                                 ` <20170729222127.GB16460-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-30 15:21                                                                   ` Marcus Wolf
2017-07-30 15:21                                                                     ` Marcus Wolf
     [not found]                                                     ` <CAMuHMdVgw=V6f8wzcXvS3gk8GK0bOpdgs_jxL6Y_X9idJD_x3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-20 15:57                                                       ` Test of " Marcus Wolf
2017-07-20 15:57                                                         ` Marcus Wolf
2017-07-17  6:18                                         ` [PATCH 1/1] drivers/staging/pi433: New driver kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170720113150.GA25299@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus.wolf@wolf-entwicklungen.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.