All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lukáš Doktor" <ldoktor@redhat.com>
To: ldoktor@redhat.com, apahim@redhat.com, qemu-devel@nongnu.org,
	famz@redhat.com, armbru@redhat.com, mreitz@redhat.com,
	ehabkost@redhat.com
Subject: [Qemu-devel] [PATCH 00/11] qemu.py: Pylint/style fixes
Date: Thu, 20 Jul 2017 18:28:04 +0200	[thread overview]
Message-ID: <20170720162815.19802-1-ldoktor@redhat.com> (raw)

Hello guys,

I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.

Kind regards,
Lukáš

Lukáš Doktor (11):
  qemu.py: Pylint/style fixes
  qemu.py: Avoid dangerous arguments
  qemu.py: Use iteritems rather than keys()
  qemu.py: Simplify QMP key-conversion
  qemu.py: Use custom exceptions rather than Exception
  qmp.py: Couple of pylint/style fixes
  qmp.py: Use object-based class for QEMUMonitorProtocol
  qmp.py: Avoid "has_key" usage
  qmp.py: Avoid overriding a builtin object
  qtest.py: Few pylint/style fixes
  qtest.py: Avoid using mutable list as default argument

 scripts/qemu.py    | 98 +++++++++++++++++++++++++++++++++++++++---------------
 scripts/qmp/qmp.py | 49 ++++++++++++++++-----------
 scripts/qtest.py   | 14 ++++----
 3 files changed, 108 insertions(+), 53 deletions(-)

-- 
2.9.4

             reply	other threads:[~2017-07-20 16:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 16:28 Lukáš Doktor [this message]
2017-07-20 16:28 ` [Qemu-devel] [PATCH 01/11] qemu.py: Pylint/style fixes Lukáš Doktor
2017-07-21  5:28   ` Philipp Hahn
2017-07-20 16:28 ` [Qemu-devel] [PATCH 02/11] qemu.py: Avoid dangerous arguments Lukáš Doktor
2017-07-20 18:19   ` Eduardo Habkost
2017-07-22  1:22   ` Philippe Mathieu-Daudé
2017-07-20 16:28 ` [Qemu-devel] [PATCH 03/11] qemu.py: Use iteritems rather than keys() Lukáš Doktor
2017-07-20 18:19   ` Eduardo Habkost
2017-07-22  1:22   ` Philippe Mathieu-Daudé
2017-07-20 16:28 ` [Qemu-devel] [PATCH 04/11] qemu.py: Simplify QMP key-conversion Lukáš Doktor
2017-07-20 18:20   ` Eduardo Habkost
2017-07-20 16:28 ` [Qemu-devel] [PATCH 05/11] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-07-20 18:27   ` Eduardo Habkost
2017-07-21  6:37     ` Lukáš Doktor
2017-07-21 18:42       ` Eduardo Habkost
2017-07-24 12:13         ` Lukáš Doktor
2017-07-24 15:32           ` Eduardo Habkost
2017-07-25  5:34             ` Lukáš Doktor
2017-07-20 16:28 ` [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-07-22  1:30   ` Philippe Mathieu-Daudé
2017-07-24 12:36     ` Lukáš Doktor
2017-07-25  6:04       ` Philippe Mathieu-Daudé
2017-07-25  6:13         ` Lukáš Doktor
2017-07-25  6:20           ` Philippe Mathieu-Daudé
2017-07-20 16:28 ` [Qemu-devel] [PATCH 07/11] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-07-20 18:35   ` Eduardo Habkost
2017-07-21  6:50     ` Lukáš Doktor
2017-07-21 18:43       ` Eduardo Habkost
2017-07-20 16:28 ` [Qemu-devel] [PATCH 08/11] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-07-20 18:35   ` Eduardo Habkost
2017-07-22  1:31   ` Philippe Mathieu-Daudé
2017-07-20 16:28 ` [Qemu-devel] [PATCH 09/11] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-07-20 18:38   ` Eduardo Habkost
2017-07-21  6:53     ` Lukáš Doktor
2017-07-21 18:46       ` Eduardo Habkost
2017-07-24 12:41         ` Lukáš Doktor
2017-07-20 16:28 ` [Qemu-devel] [PATCH 10/11] qtest.py: Few pylint/style fixes Lukáš Doktor
2017-07-20 18:42   ` Eduardo Habkost
2017-07-21  6:57     ` Lukáš Doktor
2017-07-21 18:56       ` Eduardo Habkost
2017-07-24 12:42         ` Lukáš Doktor
2017-07-20 16:28 ` [Qemu-devel] [PATCH 11/11] qtest.py: Avoid using mutable list as default argument Lukáš Doktor
2017-07-20 18:44   ` Eduardo Habkost
2017-07-21  6:58     ` Lukáš Doktor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170720162815.19802-1-ldoktor@redhat.com \
    --to=ldoktor@redhat.com \
    --cc=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=famz@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.