From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Date: Thu, 20 Jul 2017 17:15:23 -0300 Message-ID: <20170720171523.4812a8b4@vento.lan> References: <20170717215912.26070-1-toshi.kani@hpe.com> <20170717215912.26070-4-toshi.kani@hpe.com> <20170718060007.GB8736@nazgul.tnic> <1500407379.2042.21.camel@hpe.com> <20170718181545.32bd9181@vento.lan> <1500481869.2042.29.camel@hpe.com> <20170720043344.GC14367@nazgul.tnic> <1500579646.2042.37.camel@hpe.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:38892 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965009AbdGTUPd (ORCPT ); Thu, 20 Jul 2017 16:15:33 -0400 In-Reply-To: <1500579646.2042.37.camel@hpe.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Kani, Toshimitsu" Cc: "bp@alien8.de" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Em Thu, 20 Jul 2017 19:50:03 +0000 "Kani, Toshimitsu" escreveu: > On Thu, 2017-07-20 at 06:33 +0200, Borislav Petkov wrote: > > On Wed, Jul 19, 2017 at 04:40:25PM +0000, Kani, Toshimitsu wrote: > > >  ghes_edac allows to report errors to OS management tools like > > > rasdaemon in addition to platform- specific managements. > > > > So ghes_edac *is* a poor man's driver in the sense that it doesn't do > > anything fancy but repeat like a parrot data it has gotten from the > > firmware and shoving it into the EDAC counters. At least that's the > > intention. Nothing more. > > Right for ghes_edac. > > > All the action stuff like error detection and recovery should be done > > by the firmware. > > GHES / firmware-first still requires OS recovery actions when an error > cannot be corrected by the platform. They are handled by ghes_proc(), > and ghes_edac remains its error-reporting wrapper. > > > But considering how SNAFU'd firmware is, I wouldn't expect any great > > RAS functionality there. Of course, I'd be delighted to be proven > > wrong. > > Firmware has better knowledge about the platform and can provide better > RAS when implemented properly. I agree that user experiences may vary > on platforms. It may have a better knowledge, when the vendor ships different BIOS for platforms with different motherboard silkscreens, but a lot of vendors just use the same BIOS on different models, with the same information at "Locator" and "Bank Locator" data at DMI tables, that don't match what's printed at the board's silkscreen. So, GHES ends by exposing wrong data. Also, such BIOS fail to properly expose such knowledge to drivers/userspace. On the discussions I had with HP, back in 2012, the idea was to try to have some sort of way for the GHES driver to query the BIOS on a reliable way, in order to get its layout, in a way that tools like ras-mc-ctl would properly report the memory configuration (with --layout) and the motherboard silkscreen labels (with --print-labels). Unfortunately, at least on that time, the discussions with HP didn't proceed. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] ghes_edac: add platform check to enable ghes_edac From: Mauro Carvalho Chehab Message-Id: <20170720171523.4812a8b4@vento.lan> Date: Thu, 20 Jul 2017 17:15:23 -0300 To: "Kani, Toshimitsu" Cc: "bp@alien8.de" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" List-ID: RW0gVGh1LCAyMCBKdWwgMjAxNyAxOTo1MDowMyArMDAwMAoiS2FuaSwgVG9zaGltaXRzdSIgPHRv c2hpLmthbmlAaHBlLmNvbT4gZXNjcmV2ZXU6Cgo+IE9uIFRodSwgMjAxNy0wNy0yMCBhdCAwNjoz MyArMDIwMCwgQm9yaXNsYXYgUGV0a292IHdyb3RlOgo+ID4gT24gV2VkLCBKdWwgMTksIDIwMTcg YXQgMDQ6NDA6MjVQTSArMDAwMCwgS2FuaSwgVG9zaGltaXRzdSB3cm90ZTogIAo+ID4gPiDCoGdo ZXNfZWRhYyBhbGxvd3MgdG8gcmVwb3J0IGVycm9ycyB0byBPUyBtYW5hZ2VtZW50IHRvb2xzIGxp a2UKPiA+ID4gcmFzZGFlbW9uIGluIGFkZGl0aW9uIHRvIHBsYXRmb3JtLSBzcGVjaWZpYyBtYW5h Z2VtZW50cy4gIAo+ID4gCj4gPiBTbyBnaGVzX2VkYWMgKmlzKiBhIHBvb3IgbWFuJ3MgZHJpdmVy IGluIHRoZSBzZW5zZSB0aGF0IGl0IGRvZXNuJ3QgZG8KPiA+IGFueXRoaW5nIGZhbmN5IGJ1dCBy ZXBlYXQgbGlrZSBhIHBhcnJvdCBkYXRhIGl0IGhhcyBnb3R0ZW4gZnJvbSB0aGUKPiA+IGZpcm13 YXJlIGFuZCBzaG92aW5nIGl0IGludG8gdGhlIEVEQUMgY291bnRlcnMuIEF0IGxlYXN0IHRoYXQn cyB0aGUKPiA+IGludGVudGlvbi4gTm90aGluZyBtb3JlLiAgIAo+IAo+IFJpZ2h0IGZvciBnaGVz X2VkYWMuCj4gCj4gPiBBbGwgdGhlIGFjdGlvbiBzdHVmZiBsaWtlIGVycm9yIGRldGVjdGlvbiBh bmQgcmVjb3Zlcnkgc2hvdWxkIGJlIGRvbmUKPiA+IGJ5IHRoZSBmaXJtd2FyZS4gIAo+IAo+IEdI RVMgLyBmaXJtd2FyZS1maXJzdCBzdGlsbCByZXF1aXJlcyBPUyByZWNvdmVyeSBhY3Rpb25zwqB3 aGVuIGFuIGVycm9yCj4gY2Fubm90IGJlIGNvcnJlY3RlZCBieSB0aGUgcGxhdGZvcm0uICBUaGV5 IGFyZSBoYW5kbGVkIGJ5IGdoZXNfcHJvYygpLAo+IGFuZCBnaGVzX2VkYWMgcmVtYWlucyBpdHMg ZXJyb3ItcmVwb3J0aW5nIHdyYXBwZXIuCj4gCj4gPiBCdXQgY29uc2lkZXJpbmcgaG93IFNOQUZV J2QgZmlybXdhcmUgaXMsIEkgd291bGRuJ3QgZXhwZWN0IGFueSBncmVhdAo+ID4gUkFTIGZ1bmN0 aW9uYWxpdHkgdGhlcmUuIE9mIGNvdXJzZSwgSSdkIGJlIGRlbGlnaHRlZCB0byBiZSBwcm92ZW4K PiA+IHdyb25nLiAgCj4gCj4gRmlybXdhcmUgaGFzIGJldHRlciBrbm93bGVkZ2UgYWJvdXQgdGhl IHBsYXRmb3JtIGFuZCBjYW4gcHJvdmlkZSBiZXR0ZXIKPiBSQVMgd2hlbiBpbXBsZW1lbnRlZCBw cm9wZXJseS4gIEkgYWdyZWUgdGhhdCB1c2VyIGV4cGVyaWVuY2VzIG1heSB2YXJ5Cj4gb24gcGxh dGZvcm1zLgoKSXQgbWF5IGhhdmUgYSBiZXR0ZXIga25vd2xlZGdlLCB3aGVuIHRoZSB2ZW5kb3Ig c2hpcHMgZGlmZmVyZW50IEJJT1MKZm9yIHBsYXRmb3JtcyB3aXRoIGRpZmZlcmVudCBtb3RoZXJi b2FyZCBzaWxrc2NyZWVucywgYnV0IGEgbG90IG9mCnZlbmRvcnMganVzdCB1c2UgdGhlIHNhbWUg QklPUyBvbiBkaWZmZXJlbnQgbW9kZWxzLCB3aXRoIHRoZSBzYW1lCmluZm9ybWF0aW9uIGF0ICJM b2NhdG9yIiBhbmQgIkJhbmsgTG9jYXRvciIgZGF0YSBhdCBETUkgdGFibGVzLAp0aGF0IGRvbid0 IG1hdGNoIHdoYXQncyBwcmludGVkIGF0IHRoZSBib2FyZCdzIHNpbGtzY3JlZW4uCgpTbywgR0hF UyBlbmRzIGJ5IGV4cG9zaW5nIHdyb25nIGRhdGEuIEFsc28sIHN1Y2ggQklPUyBmYWlsCnRvIHBy b3Blcmx5IGV4cG9zZSBzdWNoIGtub3dsZWRnZSB0byBkcml2ZXJzL3VzZXJzcGFjZS4KCk9uIHRo ZSBkaXNjdXNzaW9ucyBJIGhhZCB3aXRoIEhQLCBiYWNrIGluIDIwMTIsIHRoZSBpZGVhIHdhcyB0 byB0cnkgCnRvIGhhdmUgc29tZSBzb3J0IG9mIHdheSBmb3IgdGhlIEdIRVMgZHJpdmVyIHRvIHF1 ZXJ5IHRoZSBCSU9TCm9uIGEgcmVsaWFibGUgd2F5LCBpbiBvcmRlciB0byBnZXQgaXRzIGxheW91 dCwgaW4gYSB3YXkKdGhhdCB0b29scyBsaWtlIHJhcy1tYy1jdGwgd291bGQgcHJvcGVybHkgcmVw b3J0IHRoZSBtZW1vcnkKY29uZmlndXJhdGlvbiAod2l0aCAtLWxheW91dCkgYW5kIHRoZSBtb3Ro ZXJib2FyZCBzaWxrc2NyZWVuCmxhYmVscyAod2l0aCAtLXByaW50LWxhYmVscykuIFVuZm9ydHVu YXRlbHksIGF0IGxlYXN0IG9uIHRoYXQKdGltZSwgdGhlIGRpc2N1c3Npb25zIHdpdGggSFAgZGlk bid0IHByb2NlZWQuCgpUaGFua3MsCk1hdXJvCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMg bGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtZWRhYyIgaW4KdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8g aW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==