All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andy Shevchenko <andy@infradead.org>,
	Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV
Date: Thu, 20 Jul 2017 17:02:42 -0700	[thread overview]
Message-ID: <20170721000242.GD16076@fury> (raw)
In-Reply-To: <20170720160114.3261176-1-arnd@arndb.de>

On Thu, Jul 20, 2017 at 06:00:50PM +0200, Arnd Bergmann wrote:
> The new driver fails to build without INPUT_POLLDEV
> 
> drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_exit':
> peaq-wmi.c:(.exit.text+0x1c): undefined reference to `input_unregister_polled_device'
> drivers/platform/x86/peaq-wmi.o: In function `peaq_wmi_init':
> peaq-wmi.c:(.init.text+0x23): undefined reference to `input_allocate_polled_device'
> peaq-wmi.c:(.init.text+0x18e): undefined reference to `input_register_polled_device'
> 
> For some reason, all other drivers that need this use 'select'
> here rather than 'depends on', so I'm doing the same.
> 
> Fixes: 13bb0fd5519d ("platform/x86: peaq-wmi: Add new peaq-wmi driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Queued to fixes branch for 4.13-rcX. I'll leave patch 2/2 to andy since you
worked that one together already.

-- 
Darren Hart
VMware Open Source Technology Center

      parent reply	other threads:[~2017-07-21  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20 16:00 [PATCH 1/2] platform/x86: peaq-wmi: select INPUT_POLLDEV Arnd Bergmann
2017-07-20 16:00 ` [PATCH 2/2] platform/x86: alienware-wmi: fix format string overflow warning Arnd Bergmann
2017-07-24  9:22   ` Andy Shevchenko
2017-07-25  7:23     ` Arnd Bergmann
2017-07-21  0:02 ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170721000242.GD16076@fury \
    --to=dvhart@infradead.org \
    --cc=andy@infradead.org \
    --cc=arnd@arndb.de \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.