All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add option to the gst1-plugins-bad package to enable/disable the qt plugin.
Date: Fri, 21 Jul 2017 11:22:25 +0200	[thread overview]
Message-ID: <20170721112225.748ac7a5@windsurf> (raw)
In-Reply-To: <CADujc4qKisW=6QyDZjDSUo50Yj+_H4-+7V=2KW32cAzRB_d2Qw@mail.gmail.com>

Hello,

On Fri, 21 Jul 2017 17:13:07 +0800, Glenn Coombs wrote:

> +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_QT
> +       bool "qt"

Don't you need Qt to be built for this plugin to be compiled?

I would expect some "depends on" on Qt here.

Also, what about qt4 vs. qt5 ?

> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_QT),y)
> +GST1_PLUGINS_BAD_CONF_OPTS += --enable-qt

I would expect a GST1_PLUGINS_BAD_DEPENDENCIES += statement here, to
make sure qt or qt5 get built before GStreamer.

Or is Qt not needed to built GStreamer Qt support ?

Also, we have to be careful, because qt5base itself can depend on
gst1-plugins-base, so we need to be careful to not introduce a circular
dependency.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-21  9:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21  9:13 [Buildroot] [PATCH 1/1] Add option to the gst1-plugins-bad package to enable/disable the qt plugin Glenn Coombs
2017-07-21  9:22 ` Thomas Petazzoni [this message]
2017-07-24  6:19   ` Glenn Coombs
2017-08-23 12:32     ` Thomas Petazzoni
2018-07-23  8:55 ` [Buildroot] [PATCH 1/1] gst1-plugins-good: add option for qmlgl plugin (qt5 plugin) Iñigo Huguet
2018-07-23 11:10   ` Iñigo Huguet
2018-07-28 22:22   ` Arnout Vandecappelle
2018-08-02 11:11     ` Iñigo Huguet
2018-08-14 14:22       ` Thomas Petazzoni
2018-08-15 19:02       ` Peter Seiderer
2018-09-03  7:14         ` [Buildroot] [PATCH v3] " Iñigo Huguet
2018-09-03 11:59           ` Martin Kepplinger
2018-09-08 20:07           ` Thomas Petazzoni
2018-09-12  6:46             ` Iñigo Huguet
2018-09-12  7:38               ` Thomas Petazzoni
2018-09-18 10:58           ` [Buildroot] [PATCH v4] " Iñigo Huguet
2019-04-07 13:36             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170721112225.748ac7a5@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.