Re: [Qemu-devel] [PATCH] io: fix temp directory used by test-io-channel-tls test

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Daniel P. Berrange (berrange@redhat.com) wrote:
> The test-io-channel-tls test was mistakenly using two of the
> same directories as test-crypto-tlssession. This causes a
> sporadic failure when using make -j$BIGNUM.
> 
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  tests/test-io-channel-tls.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c
> index 8eaa208e1b..ff96877323 100644
> --- a/tests/test-io-channel-tls.c
> +++ b/tests/test-io-channel-tls.c
> @@ -127,8 +127,8 @@ static void test_io_channel_tls(const void *opaque)
>      /* We'll use this for our fake client-server connection */
>      g_assert(socketpair(AF_UNIX, SOCK_STREAM, 0, channel) == 0);
>  
> -#define CLIENT_CERT_DIR "tests/test-crypto-tlssession-client/"
> -#define SERVER_CERT_DIR "tests/test-crypto-tlssession-server/"
> +#define CLIENT_CERT_DIR "tests/test-io-channel-tls-client/"
> +#define SERVER_CERT_DIR "tests/test-io-channel-tls-server/"

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>      mkdir(CLIENT_CERT_DIR, 0700);
>      mkdir(SERVER_CERT_DIR, 0700);
>  
> -- 
> 2.13.3
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK