From: Brian Norris <computersforpeace@gmail.com>
To: "Mario J. Rugiero" <mrugiero@gmail.com>
Cc: linux-mtd@lists.infradead.org,
boris.brezillon@free-electrons.com, marek.vasut@gmail.com,
richard@nod.at, cyrille.pitchen@wedev4u.fr
Subject: Re: [PATCH v8] mtd: create per-device and module-scope debugfs entries
Date: Fri, 21 Jul 2017 13:25:46 -0700 [thread overview]
Message-ID: <20170721202546.GL55942@google.com> (raw)
In-Reply-To: <20170529113841.3850-1-mrugiero@gmail.com>
On Mon, May 29, 2017 at 08:38:41AM -0300, Mario J. Rugiero wrote:
> Several MTD devices are using debugfs entries created in the root.
> This commit provides the means for a standardized subtree, creating
> one "mtd" entry at root, and one entry per device inside it, named
> after the device.
> The tree is registered in add_mtd_device, and released in
> del_mtd_device.
> Devices docg3, mtdswap and nandsim were updated to use this subtree
> instead of custom ones, and their entries were prefixed with the
> drivers' names.
>
> Signed-off-by: Mario J. Rugiero <mrugiero@gmail.com>
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> v8: - fix CONFIG_DEBUG_FS typo.
> v7: - as per derRichard and bbrezillon suggestion, dev_names are used
> instead of 'pretty' names for the entries, and driver-specific
> entries are prefixed with the drivers' names.
> v6: - as per bbrezillon suggestion, more cleanups were done in the drivers,
> removing now unused structure members and functions.
> - dropped explicit setting to NULL to the dfs_dir member for the MTD,
> as it is expected to be zeroed out, thanks again to bbrezillon for
> pointing this out.
> - removed an extern declaration of a symbol which was never defined,
> spotted by bbrezillon.
> v5: - cleanup drivers creating their own debugfs sub-tree.
> - separate the patch again, as it makes sense on its own as cleanup.
> v4: - include in a bigger patchset which explains the use of this tree.
> v3: - move the changelog out of the commit message
> v2: - remove unused macros and add a commit message
> v1: - create the debugfs entries
Applied to l2-mtd.git
prev parent reply other threads:[~2017-07-21 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 15:56 [PATCH] mtd: create per-device and module-scope debugfs entries Mario J. Rugiero
2017-05-16 16:17 ` Boris Brezillon
2017-05-22 15:07 ` [PATCH v5] " Mario J. Rugiero
2017-05-22 16:13 ` Boris Brezillon
2017-05-22 18:56 ` [PATCH v6] " Mario J. Rugiero
2017-05-29 10:23 ` [PATCH v7] " Mario J. Rugiero
2017-05-29 11:29 ` Boris Brezillon
2017-05-29 11:38 ` [PATCH v8] " Mario J. Rugiero
2017-07-21 20:25 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721202546.GL55942@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mrugiero@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.