From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
keescook@chromium.org, matt@codeblueprint.co.uk,
tglx@linutronix.de, hpa@zytor.com, izumi.taku@jp.fujitsu.com,
fanc.fnst@cn.fujitsu.com, thgarnie@google.com,
n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions
Date: Sat, 22 Jul 2017 07:43:27 +0800 [thread overview]
Message-ID: <20170721234327.GA24530@x1> (raw)
In-Reply-To: <20170721173753.54mn7udl6byzq2yh@gmail.com>
On 07/21/17 at 07:37pm, Ingo Molnar wrote:
>
> * Baoquan He <bhe@redhat.com> wrote:
>
> > > > +static inline bool process_efi_entries(unsigned long minimum,
> > > > + unsigned long image_size)
> > >
> > > ugly linebreak again ...
> >
> > The whole line is more than 80. I break the line and use tab and space
> > to make it align with above 'unsigned long minimum'. Don't know why it
> > becomes messy in patch. Will check and try again.
>
> Then make the linebreak less ugly, or ignore the checkpatch warning!
>
> This commonly used pattern:
>
> static inline bool
> process_efi_entries(unsigned long minimum, unsigned long image_size)
>
> looks a lot better than the function parameter list broken in the middle.
Got it, will use this one. Thanks a lot!
next prev parent reply other threads:[~2017-07-21 23:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 9:16 [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions Baoquan He
2017-07-21 10:33 ` Ingo Molnar
2017-07-21 12:35 ` Baoquan He
2017-07-21 10:37 ` Ingo Molnar
2017-07-21 13:19 ` Baoquan He
2017-07-21 17:37 ` Ingo Molnar
2017-07-21 23:43 ` Baoquan He [this message]
2017-07-24 13:34 ` Matt Fleming
2017-07-25 0:23 ` Baoquan He
2017-07-28 8:06 ` Baoquan He
2017-07-28 9:55 ` Ingo Molnar
2017-07-28 10:18 ` Baoquan He
2017-07-28 10:38 ` Baoquan He
2017-07-28 11:26 ` Baoquan He
2017-08-04 11:23 ` Matt Fleming
2017-08-04 11:23 ` Matt Fleming
[not found] ` <20170804112325.GB8187-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2017-08-04 11:40 ` Baoquan He
2017-08-04 11:40 ` Baoquan He
2017-08-04 11:55 ` Matt Fleming
2017-08-04 12:02 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721234327.GA24530@x1 \
--to=bhe@redhat.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.