From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH 1/3] sparc64: recognize and support sparc M8 cpu type
Date: Sat, 22 Jul 2017 09:25:35 +0000 [thread overview]
Message-ID: <20170722092535.GA7248@ravnborg.org> (raw)
In-Reply-To: <1500536437-14589-1-git-send-email-allen.pais@oracle.com>
On Sat, Jul 22, 2017 at 02:26:25PM +0530, Allen wrote:
> Sam/David,
> >
> >It is way better than the hardcoded values.
> >If the vales have any sort of name in the sparc specs
> >the values shall be prefixed with this.
> >Otherwise something like
> >CPU_ID_xxx
> >
> >And maybe add an intro comment like this:
> >/* following CPU_ID_xxx constants are used to identify the
> > * CPU type in the setup phase (see xxx.S)
> >*/
> >
>
> Here's a quick diff. Let me know if this looks good to you guys.
> I'll send out the patch. I have tested this on a T4.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2017-07-22 9:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 7:52 [PATCH 1/3] sparc64: recognize and support sparc M8 cpu type Allen Pais
2017-07-20 19:52 ` Sam Ravnborg
2017-07-21 8:37 ` Allen
2017-07-21 9:33 ` Allen
2017-07-21 10:46 ` Richard Mortimer
2017-07-21 10:55 ` Allen
2017-07-21 16:56 ` Sam Ravnborg
2017-07-21 19:11 ` David Miller
2017-07-22 8:56 ` Allen
2017-07-22 9:25 ` Sam Ravnborg [this message]
2017-07-23 6:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170722092535.GA7248@ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.