From: Johan Hovold <johan@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Johan Hovold <johan@kernel.org>,
Shreeya Patel <shreeya.patel23498@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org
Subject: Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.
Date: Sun, 23 Jul 2017 14:54:14 +0200 [thread overview]
Message-ID: <20170723125414.GG2729@localhost> (raw)
In-Reply-To: <20170723121053.b2sjrdsenkzjetti@mwanda>
On Sun, Jul 23, 2017 at 03:10:53PM +0300, Dan Carpenter wrote:
> On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote:
> > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote:
> > > Alignment should match with open parenthesis.
> > > This fixes the coding style issue.
> >
> > No, it need not. This is a choice left up to the author, even if
> > checkpatch happens to complain about it with the --strict option.
> >
>
> This is staging code. Don't try to fight checkpatch.pl in staging...
> You're just making work for everyone else (me) who already just reviewed
> this patch and I don't want to review it a few more times when the next
> person sends the exact same patch.
You can just ignore any greybus patches if you prefer.
I've considered patching checkpatch to drop --strict for at least this
subsystem, but not sure it's worth it.
Johan
next prev parent reply other threads:[~2017-07-23 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-23 8:39 [PATCH] Staging: greybus: Match alignment with open parenthesis Shreeya Patel
2017-07-23 8:47 ` Johan Hovold
2017-07-23 12:10 ` Dan Carpenter
2017-07-23 12:54 ` Johan Hovold [this message]
2017-07-24 7:08 ` Dan Carpenter
2017-07-28 4:49 ` Greg KH
2017-07-28 9:01 ` Johan Hovold
2017-07-28 4:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170723125414.GG2729@localhost \
--to=johan@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreeya.patel23498@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.