From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails Date: Sun, 23 Jul 2017 11:43:53 -0400 Message-ID: <20170723154353.GT28014@windriver.com> References: <20170723145613.14007-1-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: John Crispin Cc: Felix Fietkau , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sean Wang , linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , John Crispin List-Id: linux-mediatek@lists.infradead.org [Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails] On 23/07/2017 (Sun 17:16) John Crispin wrote: > Hi Paul > > mark sent the same patch a couple of days ago [1] OK, thanks -- I searched for mediatek in my mail and scanned netdev patchworks for patches in "New" state but didn't see it because it is apparently already in "In review" state. Paul. -- > > John > > [1] https://patchwork.ozlabs.org/patch/791550/ > > > On 23/07/17 16:56, Paul Gortmaker wrote: > >To fix: > > > >drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:1: error: unknown type name 'irqreturn_t' > >drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_handle_irq_rx': > >drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: error: 'IRQ_HANDLED' undeclared (first use in this function) > >drivers/net/ethernet/mediatek/mtk_eth_soc.c:1694:9: note: each undeclared identifier is reported only once for each function it appears in > > > >and similar follow-on errors as seen in arm allmodconfig builds. > > > >Cc: Sean Wang > >Cc: Felix Fietkau > >Cc: John Crispin > >Cc: Matthias Brugger > >Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > >Signed-off-by: Paul Gortmaker > >--- > > > >[Seen on current linux-next, where similar implicit irq includes > > were recently revealed by some header shuffle somewhere.] > > > > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > >index 7e95cf547ff1..ea15eb095d83 100644 > >--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > >+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > >@@ -16,6 +16,7 @@ > > #include > > #include > > #include > >+#include > > #include > > #include > > #include >