All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Jingjing Wu <jingjing.wu@intel.com>,
	dev@dpdk.org, Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH 0/2] fix flow rules copy functions
Date: Mon, 24 Jul 2017 11:00:38 +0200	[thread overview]
Message-ID: <20170724090038.GU19852@6wind.com> (raw)
In-Reply-To: <1500880222-13347-1-git-send-email-matan@mellanox.com>

On Mon, Jul 24, 2017 at 10:10:20AM +0300, Matan Azrad wrote:
> some issue seen when trying to test failsafe plug out and in. 
> 
> Matan Azrad (2):
>   app/testpmd: fix flow rule copy functions
>   ethdev: fix flow rule copy functions
> 
>  app/test-pmd/config.c       | 16 ++++++++++------
>  lib/librte_ether/rte_flow.c | 16 ++++++++++------
>  2 files changed, 20 insertions(+), 12 deletions(-)

Thanks!

I think the original code didn't have these functions and used the
flow_item[x].size value directly, which worked fine until I added support
for the RAW item and the RSS action. Both had to be handled through special
functions which I messed up.

Unfortunately I didn't catch it in testpmd because it doesn't do anything
with the copied data unlike the fail-safe PMD.

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

  parent reply	other threads:[~2017-07-24  9:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24  7:10 [PATCH 0/2] fix flow rules copy functions Matan Azrad
2017-07-24  7:10 ` [PATCH 1/2] app/testpmd: fix flow rule " Matan Azrad
2017-07-24  7:10 ` [PATCH 2/2] ethdev: " Matan Azrad
2017-07-24  9:00 ` Adrien Mazarguil [this message]
2017-07-24 13:47 ` [PATCH v2 0/2] fix flow rules " Matan Azrad
2017-07-24 13:47   ` [PATCH v2 1/2] app/testpmd: fix flow rule " Matan Azrad
2017-07-24 13:47   ` [PATCH v2 2/2] ethdev: " Matan Azrad
2017-07-31 12:10   ` [PATCH v2 0/2] fix flow rules " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724090038.GU19852@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=jingjing.wu@intel.com \
    --cc=matan@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.