Re: [Qemu-devel] [PATCH v2 0/5] target/s390x: cpu model cleanups + improvements

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 20 Jul 2017 14:37:16 +0200
David Hildenbrand <david@redhat.com> wrote:

> We want to reuse e.g. s390_get_feat_block() in tcg. Turns out, that
> set_bit_inv() doesn't work as expected on other architectures (if we
> want to expose the uint8_t[] based data to the VM later), so let's
> fix that.
> 
> Some other minor cleanups, including better baselining support if one
> of the MSA subfunctions part of a base model is missing.
> 
> v1 -> v2:
> - try to make the compiler not spit out warnings

It seems you were successful :)

> 
> David Hildenbrand (5):
>   target/s390x: drop BE_BIT()
>   target/s390x: indicate query subfunction in s390_fill_feat_block
>   target/s390x: introduce (test|set)_be_bit
>   s390x/kvm: better comment regarding zPCI feature availability
>   target/s390x: improve baselining if certain base features are missing
> 
>  target/s390x/cpu_features.c | 33 +++++++++++++++++++++++++++------
>  target/s390x/cpu_features.h |  9 ++++++++-
>  target/s390x/cpu_models.c   | 33 +++++++++++++++++++++++++++++++++
>  target/s390x/kvm.c          | 29 +++--------------------------
>  4 files changed, 71 insertions(+), 33 deletions(-)

I think this is still 2.10 material.

Thanks, queued to s390-next.