From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Date: Mon, 24 Jul 2017 13:04:13 -0300 Message-ID: <20170724130402.0f05c0ba@vento.lan> References: <1500650732.2042.45.camel@hpe.com> <20170721124401.5f94aba9@vento.lan> <1500654661.2042.49.camel@hpe.com> <20170721140131.40079805@vento.lan> <20170721172344.GA11316@nazgul.tnic> <1500661773.2042.53.camel@hpe.com> <20170722062853.GA2050@nazgul.tnic> <1500907209.2042.55.camel@hpe.com> <20170724150432.GA31295@nazgul.tnic> <1500909372.2042.58.camel@hpe.com> <20170724153716.GA17708@nazgul.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:50001 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752336AbdGXQEW (ORCPT ); Mon, 24 Jul 2017 12:04:22 -0400 In-Reply-To: <20170724153716.GA17708@nazgul.tnic> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Borislav Petkov Cc: "Kani, Toshimitsu" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Em Mon, 24 Jul 2017 17:37:16 +0200 Borislav Petkov escreveu: > > Customers do not see error counts.  I do not think it's bogus. > > I am just trying to enable OS error reporting with ghes_edac. > > I know, you don't have to state the obvious constantly. The problem I see is that, currently, on users that have EDAC already enabled, the users gets the errors directly from the hardware. If the Kernel force those users to use ghes_edac by default, they they won't see the error counts anymore, but, instead, hardware reports that the memories need to be replaced. Well, if such users are handling thresholds themselves, they won't see those errors anymore, as the errors will be masked. That's a regression. So, the right solution would be to keep hardware first, but providing a modprobe parameter to let them switch to software first. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] ghes_edac: add platform check to enable ghes_edac From: Mauro Carvalho Chehab Message-Id: <20170724130402.0f05c0ba@vento.lan> Date: Mon, 24 Jul 2017 13:04:13 -0300 To: Borislav Petkov Cc: "Kani, Toshimitsu" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" List-ID: RW0gTW9uLCAyNCBKdWwgMjAxNyAxNzozNzoxNiArMDIwMApCb3Jpc2xhdiBQZXRrb3YgPGJwQGFs aWVuOC5kZT4gZXNjcmV2ZXU6Cgo+ID4gQ3VzdG9tZXJzIGRvIG5vdCBzZWUgZXJyb3IgY291bnRz LsKgwqBJIGRvIG5vdCB0aGluayBpdCdzIGJvZ3VzLgoKPiA+IEkgYW0ganVzdCB0cnlpbmcgdG8g ZW5hYmxlIE9TIGVycm9yIHJlcG9ydGluZyB3aXRoIGdoZXNfZWRhYy4gIAo+IAo+IEkga25vdywg eW91IGRvbid0IGhhdmUgdG8gc3RhdGUgdGhlIG9idmlvdXMgY29uc3RhbnRseS4KClRoZSBwcm9i bGVtIEkgc2VlIGlzIHRoYXQsIGN1cnJlbnRseSwgb24gdXNlcnMgdGhhdCBoYXZlIEVEQUMKYWxy ZWFkeSBlbmFibGVkLCB0aGUgdXNlcnMgZ2V0cyB0aGUgZXJyb3JzIGRpcmVjdGx5IGZyb20gdGhl CmhhcmR3YXJlLgoKSWYgdGhlIEtlcm5lbCBmb3JjZSB0aG9zZSB1c2VycyB0byB1c2UgZ2hlc19l ZGFjIGJ5IGRlZmF1bHQsCnRoZXkgdGhleSB3b24ndCBzZWUgdGhlIGVycm9yIGNvdW50cyBhbnlt b3JlLCBidXQsIGluc3RlYWQsCmhhcmR3YXJlIHJlcG9ydHMgdGhhdCB0aGUgbWVtb3JpZXMgbmVl ZCB0byBiZSByZXBsYWNlZC4KCldlbGwsIGlmIHN1Y2ggdXNlcnMgYXJlIGhhbmRsaW5nIHRocmVz aG9sZHMgdGhlbXNlbHZlcywgdGhleQp3b24ndCBzZWUgdGhvc2UgZXJyb3JzIGFueW1vcmUsIGFz IHRoZSBlcnJvcnMgd2lsbCBiZSBtYXNrZWQuCgpUaGF0J3MgYSByZWdyZXNzaW9uLgoKU28sIHRo ZSByaWdodCBzb2x1dGlvbiB3b3VsZCBiZSB0byBrZWVwIGhhcmR3YXJlIGZpcnN0LCBidXQKcHJv dmlkaW5nIGEgbW9kcHJvYmUgcGFyYW1ldGVyIHRvIGxldCB0aGVtIHN3aXRjaCB0byBzb2Z0d2Fy ZQpmaXJzdC4KClRoYW5rcywKTWF1cm8KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0 OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1lZGFjIiBpbgp0aGUgYm9keSBvZiBh IG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZv IGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK