From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v1 3/3] xen/livepatch/ARM32: Don't crash on livepatches loaded with wrong alignment. Date: Mon, 24 Jul 2017 09:14:08 -0400 Message-ID: <20170724131408.GE17195@char.us.oracle.com> References: <20170711165313.26497-1-konrad.wilk@oracle.com> <20170711165313.26497-4-konrad.wilk@oracle.com> <59652FB1020000780010228C@prv-mh.provo.novell.com> <20170711203344.GA4908@char.us.oracle.com> <5965BC9502000078001022CA@prv-mh.provo.novell.com> <3e12fa40-c75e-d8c0-cd6c-0e53a6289950@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZdBm-0007Vl-HC for xen-devel@lists.xenproject.org; Mon, 24 Jul 2017 13:14:22 +0000 Content-Disposition: inline In-Reply-To: <3e12fa40-c75e-d8c0-cd6c-0e53a6289950@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Julien Grall Cc: andrew.cooper3@citrix.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org, Jan Beulich , ross.lagerwall@citrix.com List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBKdWwgMjQsIDIwMTcgYXQgMTE6MzQ6MjZBTSArMDEwMCwgSnVsaWVuIEdyYWxsIHdy b3RlOgo+IEhpLAo+IAo+IE9uIDEyLzA3LzE3IDA3OjA3LCBKYW4gQmV1bGljaCB3cm90ZToKPiA+ ID4gPiA+IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4gMDcv MTEvMTcgMTA6MzQgUE0gPj4+Cj4gPiA+IE9uIFR1ZSwgSnVsIDExLCAyMDE3IGF0IDAyOjA2OjA5 UE0gLTA2MDAsIEphbiBCZXVsaWNoIHdyb3RlOgo+ID4gPiA+ID4gPiA+IEtvbnJhZCBSemVzenV0 ZWsgV2lsayA8a29ucmFkLndpbGtAb3JhY2xlLmNvbT4gMDcvMTEvMTcgNjo1MyBQTSA+Pj4KPiA+ ID4gPiA+IFRoaXMgaXNzdWUgd2FzIG9ic2VydmVkIG9uIEFSTTMyIHdpdGggYSBjcm9zcyBjb21w aWxlciBmb3IgdGhlCj4gPiA+ID4gPiBsaXZlcGF0Y2hlcy4gTWFpbmx5IHRoZSBsaXZlcGF0Y2hl cyAuZGF0YSBzZWN0aW9uIHNpemUgd2FzIG5vdAo+ID4gPiA+ID4gYWxpZ25lZCB0byB0aGUgc2Vj dGlvbiBhbGlnbm1lbnQ6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFSTTMyIG5hdGl2ZToKPiA+ID4g PiA+IENvbnRlbnRzIG9mIHNlY3Rpb24gLnJvZGF0YToKPiA+ID4gPiAgPjAwMDAgNjg2OTVmNjYg NzU2ZTYzMDAgNjM2ODY1NjMgNmI1ZjY2NmUgIGhpX2Z1bmMuY2hlY2tfZm4KPiA+ID4gPiAgPjAw MTAgNjMwMDAwMDAgNzg2NTZlNWYgNjU3ODc0NzIgNjE1Zjc2NjUgIGMuLi54ZW5fZXh0cmFfdmUK PiA+ID4gPiAgPjAwMjAgNzI3MzY5NmYgNmUwMDAwMDAgICAgICAgICAgICAgICAgICAgIHJzaW9u Li4uCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFSTTMyIGNyb3NzIGNvbXBpbGVyOgo+ID4gPiA+ID4g Q29udGVudHMgb2Ygc2VjdGlvbiAucm9kYXRhOgo+ID4gPiA+ICA+MDAwMCA2ODY5NWY2NiA3NTZl NjMwMCA2MzY4NjU2MyA2YjVmNjY2ZSAgaGlfZnVuYy5jaGVja19mbgo+ID4gPiA+ICA+MDAxMCA2 MzAwMDAwMCA3ODY1NmU1ZiA2NTc4NzQ3MiA2MTVmNzY2NSAgYy4uLnhlbl9leHRyYV92ZQo+ID4g PiA+ICA+MDAyMCA3MjczNjk2ZiA2ZTAwICAgICAgICAgICAgICAgICAgICAgICAgcnNpb24uCj4g PiA+ID4gPiAKPiA+ID4gPiA+IEFuZCB3aGVuIHdlIGxvYWRlZCBpdDoKPiA+ID4gPiA+IAo+ID4g PiA+ID4gbmF0aXZlOgo+ID4gPiA+ID4gCj4gPiA+ID4gPiAoWEVOKSBsaXZlcGF0Y2guYzo0MTM6 IGxpdmVwYXRjaDogeGVuX2hlbGxvX3dvcmxkOiBMb2FkZWQgLnRleHQgYXQgMDBhMDIwMDAKPiA+ ID4gPiA+IChYRU4pIGxpdmVwYXRjaC5jOjQxMzogbGl2ZXBhdGNoOiB4ZW5faGVsbG9fd29ybGQ6 IExvYWRlZCAucm9kYXRhIGF0IDAwYTA0MDI0Cj4gPiA+ID4gPiAoWEVOKSBsaXZlcGF0Y2guYzo0 MTM6IGxpdmVwYXRjaDogeGVuX2hlbGxvX3dvcmxkOiBMb2FkZWQgLmFsdGluc3RydWN0aW9ucyBh dCAwMGEwNDA0Ywo+ID4gPiA+ID4gCj4gPiA+ID4gPiBjcm9zcyBjb21waWxlcjoKPiA+ID4gPiA+ IChYRU4pIGxpdmVwYXRjaC5jOjQxMzogbGl2ZXBhdGNoOiB4ZW5faGVsbG9fd29ybGQ6IExvYWRl ZCAudGV4dCBhdCAwMGEwMjAwMAo+ID4gPiA+ID4gKFhFTikgbGl2ZXBhdGNoLmM6NDEzOiBsaXZl cGF0Y2g6IHhlbl9oZWxsb193b3JsZDogTG9hZGVkIC5yb2RhdGEgYXQgMDBhMDQwMjQKPiA+ID4g PiA+IChYRU4pIGxpdmVwYXRjaC5jOjQxMzogbGl2ZXBhdGNoOiB4ZW5faGVsbG9fd29ybGQ6IExv YWRlZCAuYWx0aW5zdHJ1Y3Rpb25zIGF0IDAwYTA0MDRhCj4gPiA+ID4gPiAKPiA+ID4gPiA+IChT ZWUgNGEgdnMgNGMpCj4gPiA+ID4gPiAKPiA+ID4gPiA+IG5hdGl2ZSByZWFkZWxmOgo+ID4gPiA+ ICAgPlsgNF0gLnJvZGF0YSAgICAgICAgICAgUFJPR0JJVFMgICAgICAgIDAwMDAwMDAwIDAwMDE2 NCAwMDAwMjggMDAgICBBICAwICAgMCAgNAo+ID4gPiA+ICAgPlsgNV0gLmFsdGluc3RydWN0aW9u cyAgUFJPR0JJVFMgICAgICAgIDAwMDAwMDAwIDAwMDE4YyAwMDAwMGMgMDAgICBBICAwICAgMCAg MQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBjcm9zcyBjb21waWxlciByZWFkZWxmIC0tc2VjdGlvbnM6 Cj4gPiA+ID4gICA+WyA0XSAucm9kYXRhICAgICAgICAgICBQUk9HQklUUyAgICAgICAgMDAwMDAw MDAgMDAwMTY0IDAwMDAyNiAwMCAgIEEgIDAgICAwICA0Cj4gPiA+ID4gICA+WyA1XSAuYWx0aW5z dHJ1Y3Rpb25zICBQUk9HQklUUyAgICAgICAgMDAwMDAwMDAgMDAwMThhIDAwMDAwYyAwMCAgIEEg IDAgICAwICAxCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEFuZCBhcyBjYW4gYmUgc2VlbiB0aGUgLmFs dGluc3RydWN0aW9ucyBoYXZlIGFsaWdubWVudCBvZiAxIHdoaWNoIGZyb20KPiA+ID4gPiA+ICdt YW4gZWxmJyBpczogIlZhbHVlcyBvZiB6ZXJvIGFuZCBvbmUgbWVhbiBubyBhbGlnbm1lbnQgaXMg cmVxdWlyZWQuIgo+ID4gPiA+ID4gd2hpY2ggbWVhbnMgd2UgY2FuIGlnbm9yZSBpdC4KPiA+ID4g PiA+IAo+ID4gPiA+ID4gSG93ZXZlciBpZ25vcmluZyB0aGlzIHdpbGwgcmVzdWx0IGluIGEgY3Jh c2ggYXMgd2hlbiB3ZSBzdGFydGVkIHByb2Nlc3NpbmcKPiA+ID4gPiA+ICIucmVsLmFsdGluc3Ry dWN0aW9ucyIgZm9yICIuYWx0aW5zdHJ1Y3Rpb25zIiB3aXRoIGEgY3Jvc3MtY29tcGlsZWQgcGF5 bG9hZAo+ID4gPiA+ID4gd2Ugd291bGQgZW5kIHVwIHBva2luZyBpbiBhbiBzZWN0aW9uIHRoYXQg d2FzIG5vdCBhbGlnbmVkIHByb3Blcmx5IGluIG1lbW9yeQo+ID4gPiA+ID4gYW5kIGNyYXNoLgo+ ID4gPiA+IAo+ID4gPiA+IFdoaWNoIHNlY3Rpb24gaXMgaXQgdGhhdCB3b3VsZCBub3QgYmUgYWxp Z25lZCBwcm9wZXJseSBpbiBtZW1vcnk/Cj4gPiA+IAo+ID4gPiAuYWx0aW5zdHJ1Y3Rpb25zLCB0 aGFua3MgdG8gLnJvZGF0YSBub3QgYmVpbmcgcGFkZGVkIHByb3Blcmx5Lgo+ID4gPiAKPiA+ID4g PiAuYWx0aW5zdHJ1Y3Rpb25zLCB3aXRoIGFuIGFsaWdubWVudCBvZiAxLCBjYW4gYmUgcGxhY2Vk IGFueXdoZXJlLiBZb3UKPiA+ID4gPiBzaG91bGRuJ3QgZW5mb3JjZSBleHRyYSBhbGlnbm1lbnQu IElmIGhpZ2hlciBhbGlnbm1lbnQgaXMgbmVlZGVkLCB0aGUKPiA+ID4gPiBjb2RlIHByb2R1Y2lu ZyB0aGlzIHNlY3Rpb24gZW1pc3Npb24gbmVlZHMgdG8gYmUgZml4ZWQuCj4gPiA+IAo+ID4gPiBB bmQgdGhlcmUgaXMgdGhlIHBhdGggdG8gbWFkbmVzcyA6LSkgV2Ugd291bGQgbmVlZCB0byBwcm92 aWRlIGFuCj4gPiA+IGxpbmtlciBtYXAgdG8gbWFrZSBzdXJlIHRoYXQgdGhleSBhcmUgd2l0aCB0 aGUgY29ycmVjdCBhbGlnbm1lbnQuCj4gPiAKPiA+IFdoeT8gSSdkIGV4cGVjdCBpdCB0byBiZSB0 aGUgYXNzZW1ibGVyIGRpcmVjdGl2ZXMgY3JlYXRpbmcgY29udHJpYnV0aW9ucyB0bwo+ID4gdGhh dCBzZWN0aW9uIHRvIHNpbXBseSBsYWNrIGEgLmFsaWduIG9yIGFsaWtlLiBBbmQgaW5kZWVkLCB0 aGVyZSdzIG5vdGhpbmcKPiA+IGxpa2UgdGhhdCBpbiBBUk0ncyBhbHRlcm5hdGl2ZS5oLiBQbGVh c2Ugc2VlIGNvbW1pdCAwMWZlNGRhNjI0ICgieDg2OiBmb3JjZQo+ID4gc3VpdGFibGUgYWxpZ25t ZW50IGluIHNvdXJjZXMgcmF0aGVyIHRoYW4gaW4gbGlua2VyIHNjcmlwdCIpIGZvciBmdXJ0aGVy Cj4gPiBjb250ZXh0Lgo+IAo+IEZXSVcsIEkgYWdyZWUgd2l0aCBKYW4gaGVyZS4gLmFsdGluc3Ry dWN0aW9ucyBzZWN0aW9uIHNob3VsZCBjb250YWluIHRoZQo+IHJpZ2h0IGFsaWdubWVudCBpbiB0 aGUgc291cmNlIGNvZGUuCgpTdXJlLgoKUmVnYXJkbGVzcyBvZiB0aGF0ICAtIHNob3VsZCB0aGlz IGNvZGUgd2hpY2ggY2F0Y2hlcyBlcnJhbnQgYWxpZ25tZW50cwpvZiBsaXZlcGF0Y2hlcyAoc2F5 IHRoZXkgYXJlIGdlbmVyYXRlZCBieSBvdGhlciB0b29scykgc3RpbGwgYmUgaW4gdGhlIGNvZGUg YmFzZT8KCkl0IGlzIGV4dHJhIGJlbHQgYW5kIHN1c3BlbmRlcnMuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK