All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] Fix qemu keymaps, part one
Date: Mon, 24 Jul 2017 15:23:32 +0100	[thread overview]
Message-ID: <20170724142332.GC11443@redhat.com> (raw)
In-Reply-To: <20170724141825.GB11443@redhat.com>

On Mon, Jul 24, 2017 at 03:18:25PM +0100, Daniel P. Berrange wrote:
> On Mon, Jul 24, 2017 at 04:01:14PM +0200, Gerd Hoffmann wrote:
> > qemu carries a bunch of reverse keymaps in pc-bios/keymaps/, to map
> > keysyms it receives from vnc clients back to keycodes.  These keymaps
> > seem to be buggy and incomplete at times.  So, to tackle the issue once
> > for all, I've written a tool to generate those maps from xkb keyboard
> > layout data using libxkbcommon.
> > 
> > This patch series only adds the tool, it doesn't touch the maps in
> > pc-bios/keymaps/ yet.  I want some testing feedback first ...
> 
> Hmm, we recently split out the keymap database and code for generating
> lookup tables (that was duplicated across spice-gtk, gtk-vnc, and libvirt)
> into a shared git sub-module
> 
>   https://gitlab.com/keycodemap/keycodemapdb/
> 
> some other VNC clients were also switching to its use.
> 
> I was coincidentally working on a patch to get QEMU to use this too,
> so all projects are aligned on the same data maps and thus share fixes
> in this area.
> 
> IMHO that'd be preferable than doing something custom in QEMU only.

Oh actually ignore that - we're talking about different areas of
keymapping. The stuff I was doing was primarily targetted as the
SDL / GTK frontends in QEMU which must convert from X/GTK key
maps to QEMU's XT keycodes, where as you were talking about the
VNC keymaps when not using the QEMU scancode extension for VNC.
So they're complementary, not mutually exclusive.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2017-07-24 14:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 14:01 [Qemu-devel] [PATCH 0/3] Fix qemu keymaps, part one Gerd Hoffmann
2017-07-24 14:01 ` [Qemu-devel] [PATCH 1/3] keysym: add next and prior Gerd Hoffmann
2017-07-24 14:01 ` [Qemu-devel] [PATCH 2/3] ui: move qemu_input_linux_to_qcode() Gerd Hoffmann
2017-07-24 14:01 ` [Qemu-devel] [PATCH 3/3] Add qemu-keymap tool Gerd Hoffmann
2017-07-24 14:18 ` [Qemu-devel] [PATCH 0/3] Fix qemu keymaps, part one Daniel P. Berrange
2017-07-24 14:23   ` Daniel P. Berrange [this message]
2017-07-24 14:29   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170724142332.GC11443@redhat.com \
    --to=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.