From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Date: Mon, 24 Jul 2017 15:10:13 -0300 Message-ID: <20170724151013.513d5fc8@vento.lan> References: <1500654661.2042.49.camel@hpe.com> <20170721140131.40079805@vento.lan> <20170721172344.GA11316@nazgul.tnic> <1500661773.2042.53.camel@hpe.com> <20170722062853.GA2050@nazgul.tnic> <1500907209.2042.55.camel@hpe.com> <20170724150432.GA31295@nazgul.tnic> <1500909372.2042.58.camel@hpe.com> <20170724153716.GA17708@nazgul.tnic> <20170724130402.0f05c0ba@vento.lan> <20170724164400.GB18184@nazgul.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170724164400.GB18184@nazgul.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: "Kani, Toshimitsu" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org Em Mon, 24 Jul 2017 18:44:00 +0200 Borislav Petkov escreveu: > On Mon, Jul 24, 2017 at 01:04:13PM -0300, Mauro Carvalho Chehab wrote: > > If the Kernel force those users to use ghes_edac by default, > > they they won't see the error counts anymore, but, instead, > > hardware reports that the memories need to be replaced. > > This is exactly why I'm trying to load ghes_edac only on those platforms > which would really want it. > > > So, the right solution would be to keep hardware first, but > > providing a modprobe parameter to let them switch to software > > first. > > That's exactly the issue: if we make it spec-conform and adhere to FF > setting, then it'll be clean. BUT(!), we will force ghes_edac on those > platforms which potentially are using the platform-specific drivers > until now. Not good. > > If we do the whitelisting, then we're stuck with maintaining a yucky > whitelist and have to keep updating ghes_edac with it. Yeah, having a whitelist is a maintainership's burden, but, on the other hand, I suspect that there aren't many systems that implement FF, have a reliable BIOS mapping of MB's silkscreen and doesn't filters out corrected errors using some sort of undocumented mechanism. So, I guess it is doable. Another alternative, with, IMO, is better would be to add a parameter like: edac=FF - firmware first; edac=hw - hardware first; edac=auto - honors FF if set in BIOS. Otherwise, hardware first. In order to avoid regressions, and to avoid the need of a whitelist, I would keep "edac=hw" as default. Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] ghes_edac: add platform check to enable ghes_edac From: Mauro Carvalho Chehab Message-Id: <20170724151013.513d5fc8@vento.lan> Date: Mon, 24 Jul 2017 15:10:13 -0300 To: Borislav Petkov Cc: "Kani, Toshimitsu" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "srinivas.pandruvada@linux.intel.com" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" List-ID: RW0gTW9uLCAyNCBKdWwgMjAxNyAxODo0NDowMCArMDIwMApCb3Jpc2xhdiBQZXRrb3YgPGJwQGFs aWVuOC5kZT4gZXNjcmV2ZXU6Cgo+IE9uIE1vbiwgSnVsIDI0LCAyMDE3IGF0IDAxOjA0OjEzUE0g LTAzMDAsIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZToKPiA+IElmIHRoZSBLZXJuZWwgZm9y Y2UgdGhvc2UgdXNlcnMgdG8gdXNlIGdoZXNfZWRhYyBieSBkZWZhdWx0LAo+ID4gdGhleSB0aGV5 IHdvbid0IHNlZSB0aGUgZXJyb3IgY291bnRzIGFueW1vcmUsIGJ1dCwgaW5zdGVhZCwKPiA+IGhh cmR3YXJlIHJlcG9ydHMgdGhhdCB0aGUgbWVtb3JpZXMgbmVlZCB0byBiZSByZXBsYWNlZC4gIAo+ IAo+IFRoaXMgaXMgZXhhY3RseSB3aHkgSSdtIHRyeWluZyB0byBsb2FkIGdoZXNfZWRhYyBvbmx5 IG9uIHRob3NlIHBsYXRmb3Jtcwo+IHdoaWNoIHdvdWxkIHJlYWxseSB3YW50IGl0Lgo+IAo+ID4g U28sIHRoZSByaWdodCBzb2x1dGlvbiB3b3VsZCBiZSB0byBrZWVwIGhhcmR3YXJlIGZpcnN0LCBi dXQKPiA+IHByb3ZpZGluZyBhIG1vZHByb2JlIHBhcmFtZXRlciB0byBsZXQgdGhlbSBzd2l0Y2gg dG8gc29mdHdhcmUKPiA+IGZpcnN0LiAgCj4gCj4gVGhhdCdzIGV4YWN0bHkgdGhlIGlzc3VlOiBp ZiB3ZSBtYWtlIGl0IHNwZWMtY29uZm9ybSBhbmQgYWRoZXJlIHRvIEZGCj4gc2V0dGluZywgdGhl biBpdCdsbCBiZSBjbGVhbi4gQlVUKCEpLCB3ZSB3aWxsIGZvcmNlIGdoZXNfZWRhYyBvbiB0aG9z ZQo+IHBsYXRmb3JtcyB3aGljaCBwb3RlbnRpYWxseSBhcmUgdXNpbmcgdGhlIHBsYXRmb3JtLXNw ZWNpZmljIGRyaXZlcnMKPiB1bnRpbCBub3cuIE5vdCBnb29kLgo+IAo+IElmIHdlIGRvIHRoZSB3 aGl0ZWxpc3RpbmcsIHRoZW4gd2UncmUgc3R1Y2sgd2l0aCBtYWludGFpbmluZyBhIHl1Y2t5Cj4g d2hpdGVsaXN0IGFuZCBoYXZlIHRvIGtlZXAgdXBkYXRpbmcgZ2hlc19lZGFjIHdpdGggaXQuCgpZ ZWFoLCBoYXZpbmcgYSB3aGl0ZWxpc3QgaXMgYSBtYWludGFpbmVyc2hpcCdzIGJ1cmRlbiwgYnV0 LCBvbgp0aGUgb3RoZXIgaGFuZCwgSSBzdXNwZWN0IHRoYXQgdGhlcmUgYXJlbid0IG1hbnkgc3lz dGVtcyB0aGF0CmltcGxlbWVudCBGRiwgaGF2ZSBhIHJlbGlhYmxlIEJJT1MgbWFwcGluZyBvZiBN QidzIHNpbGtzY3JlZW4KYW5kIGRvZXNuJ3QgZmlsdGVycyBvdXQgY29ycmVjdGVkIGVycm9ycyB1 c2luZyBzb21lIHNvcnQgb2YKdW5kb2N1bWVudGVkIG1lY2hhbmlzbS4KClNvLCBJIGd1ZXNzIGl0 IGlzIGRvYWJsZS4KCkFub3RoZXIgYWx0ZXJuYXRpdmUsIHdpdGgsIElNTywgaXMgYmV0dGVyIHdv dWxkIGJlIHRvIGFkZCBhIHBhcmFtZXRlciBsaWtlOgoKCWVkYWM9RkYgLSBmaXJtd2FyZSBmaXJz dDsKCWVkYWM9aHcJIC0gaGFyZHdhcmUgZmlyc3Q7CgllZGFjPWF1dG8gLSBob25vcnMgRkYgaWYg c2V0IGluIEJJT1MuIE90aGVyd2lzZSwgaGFyZHdhcmUgZmlyc3QuCgpJbiBvcmRlciB0byBhdm9p ZCByZWdyZXNzaW9ucywgYW5kIHRvIGF2b2lkIHRoZSBuZWVkIG9mIGEgd2hpdGVsaXN0LApJIHdv dWxkIGtlZXAgImVkYWM9aHciIGFzIGRlZmF1bHQuCgpUaGFua3MsCk1hdXJvCi0tLQpUbyB1bnN1 YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgt ZWRhYyIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5v cmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRv bW8taW5mby5odG1sCg==