From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZfSj-0007eO-MT for qemu-devel@nongnu.org; Mon, 24 Jul 2017 11:40:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZfSi-0006V8-V2 for qemu-devel@nongnu.org; Mon, 24 Jul 2017 11:40:01 -0400 From: Eric Blake Date: Mon, 24 Jul 2017 10:39:51 -0500 Message-Id: <20170724153952.26510-2-eblake@redhat.com> In-Reply-To: <20170724153952.26510-1-eblake@redhat.com> References: <20170724153952.26510-1-eblake@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] iotests: Check dirty bitmap statistics in 124 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, qemu-block@nongnu.org, Max Reitz We had a bug for multiple releases where dirty-bitmap count was documented in bytes but reported in sectors; enhance the testsuite to add coverage of DirtyBitmapInfo to ensure we do not regress again. Signed-off-by: Eric Blake --- tests/qemu-iotests/124 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124 index d0d2c2bfb0..8e76e62f93 100644 --- a/tests/qemu-iotests/124 +++ b/tests/qemu-iotests/124 @@ -336,7 +336,12 @@ class TestIncrementalBackup(TestIncrementalBackupBase): (('0xab', 0, 512), ('0xfe', '16M', '256k'), ('0x64', '32736k', '64k'))) - + # Check the dirty bitmap stats + result = self.vm.qmp('query-block') + self.assert_qmp(result, 'return[0]/dirty-bitmaps[0]/name', 'bitmap0') + self.assert_qmp(result, 'return[0]/dirty-bitmaps[0]/count', 458752) + self.assert_qmp(result, 'return[0]/dirty-bitmaps[0]/granularity', 65536) + self.assert_qmp(result, 'return[0]/dirty-bitmaps[0]/status', 'active') # Prepare a cluster_size=128k backup target without a backing file. (target, _) = bitmap0.new_target() -- 2.13.3