From: Sam Ravnborg <sam@ravnborg.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/9] i.MX7 SabreSD support
Date: Mon, 24 Jul 2017 18:01:58 +0200 [thread overview]
Message-ID: <20170724160158.GC18294@ravnborg.org> (raw)
In-Reply-To: <20170724145400.2279-1-andrew.smirnov@gmail.com>
Hi Andrey.
> Also, note, that for a reason I haven't been able to track down yet,
> compiling Barebox + this patchset without support for FEC will cause
> upstream kernel (at least 4.12-rc1) to hang during boot while trying
> to access FEC's register file. I suspect clock initialization issue,
> but, as I said, I did not find that out conclusively.
Maybe you should include this explanation in the patch that
enables this option?
>
> Anyway, as usual, any feedback is wellcome.
I have browsed the patches, and provided a little feedback.
Apart form this the series looks good to me.
But then for most parts I am not intiminate with the
code so do not assume too much based on this.
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-07-24 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 14:53 [PATCH 0/9] i.MX7 SabreSD support Andrey Smirnov
2017-07-24 14:53 ` [PATCH 1/9] gpiolib: Fix buggy flag detection code Andrey Smirnov
2017-07-24 15:36 ` Sam Ravnborg
2017-07-24 19:30 ` Andrey Smirnov
2017-07-24 14:53 ` [PATCH 2/9] clk: i.MX7: Remove unused UART clocks array Andrey Smirnov
2017-07-24 14:53 ` [PATCH 3/9] ARM: i.MX: Import mx7d_pins.h from U-Boot Andrey Smirnov
2017-07-24 14:53 ` [PATCH 4/9] ARM: i.MX: Add mx7_setup_pad() Andrey Smirnov
2017-07-24 14:53 ` [PATCH 5/9] ARM: i.MX: Add imx7_uart_setup_ll() Andrey Smirnov
2017-07-24 14:53 ` [PATCH 6/9] ARM: i.MX: Add minimal imx7-ccm-regs.h Andrey Smirnov
2017-07-24 14:53 ` [PATCH 7/9] ARM: i.MX: Add ARCH_HAD_FEC_IMX to ARCH_IMX7 Andrey Smirnov
2017-07-24 14:53 ` [PATCH 8/9] ARM: i.MX: Import imx7-iomuxc-gpr.h from Linux kernel Andrey Smirnov
2017-07-24 14:54 ` [PATCH 9/9] ARM: i.MX: Add support for NXP i.MX7 SABRESD board Andrey Smirnov
2017-07-24 15:59 ` Sam Ravnborg
2017-07-24 19:20 ` Andrey Smirnov
2017-07-24 19:03 ` Stefan Lengfeld
2017-07-24 19:23 ` Andrey Smirnov
2017-07-24 16:01 ` Sam Ravnborg [this message]
2017-07-24 19:29 ` [PATCH 0/9] i.MX7 SabreSD support Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724160158.GC18294@ravnborg.org \
--to=sam@ravnborg.org \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.