From: Johannes Thumshirn <jthumshirn@suse.de>
To: Himanshu Madhani <himanshu.madhani@cavium.com>
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 6/6] qla2xxx: Refactor usage of Active command arrays
Date: Tue, 25 Jul 2017 10:19:44 +0200 [thread overview]
Message-ID: <20170725081944.GF3750@linux-x5ow.site> (raw)
In-Reply-To: <20170721163228.32339-7-himanshu.madhani@cavium.com>
On Fri, Jul 21, 2017 at 09:32:28AM -0700, Himanshu Madhani wrote:
> +typedef enum {
> + TYPE_SRB,
> + TYPE_TGT_CMD,
> +} cmd_type_t;
Minor Nitpick if you have to re-send, please no typedefs.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-07-25 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 16:32 [PATCH v2 0/6] qla2xxx: Bug fixes for driver Himanshu Madhani
2017-07-21 16:32 ` [PATCH v2 1/6] qla2xxx: Cleanup FC-NVMe code Himanshu Madhani
2017-07-21 16:32 ` [PATCH v2 2/6] qla2xxx: Move function prototype to correct header Himanshu Madhani
2017-07-25 8:13 ` Johannes Thumshirn
2017-07-21 16:32 ` [PATCH v2 3/6] qla2xxx: Added change to enable ZIO for FC-NVMe devices Himanshu Madhani
2017-07-25 8:17 ` Johannes Thumshirn
2017-07-21 16:32 ` [PATCH v2 4/6] qla2xxx: Simpify unregistration of FC-NVMe local/remote ports Himanshu Madhani
2017-07-25 8:17 ` Johannes Thumshirn
2017-07-21 16:32 ` [PATCH v2 5/6] qla2xxx: Fix remoteport disconnect for FC-NVMe Himanshu Madhani
2017-07-21 16:32 ` [PATCH v2 6/6] qla2xxx: Refactor usage of Active command arrays Himanshu Madhani
2017-07-21 23:11 ` Bart Van Assche
2017-07-25 8:19 ` Johannes Thumshirn [this message]
2017-07-27 1:58 ` [PATCH v2 0/6] qla2xxx: Bug fixes for driver Martin K. Petersen
2017-07-27 3:59 ` Madhani, Himanshu
2017-07-27 12:49 ` Martin K. Petersen
2017-07-27 15:20 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725081944.GF3750@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.