From: "Daniel P. Berrange" <berrange@redhat.com>
To: Knut Omang <knut.omang@oracle.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 3/4] sockets: factor out a new try_bind() function
Date: Tue, 25 Jul 2017 10:39:21 +0100 [thread overview]
Message-ID: <20170725093921.GK26394@redhat.com> (raw)
In-Reply-To: <f65fafa6dbfe151b16cc1b2528ddb7ab7e9fbfcf.1500709594.git-series.knut.omang@oracle.com>
On Sat, Jul 22, 2017 at 09:49:32AM +0200, Knut Omang wrote:
> Another refactoring step to prepare for the problem
> exposed by the test-listen test.
>
> This time simplify and reorganize the IPv6 specific extra
> measures and move it out of the for loop to increase
> code readability. No semantic changes.
>
> Signed-off-by: Knut Omang <knut.omang@oracle.com>
> ---
> util/qemu-sockets.c | 69 ++++++++++++++++++++++++++--------------------
> 1 file changed, 39 insertions(+), 30 deletions(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-07-25 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 7:49 [Qemu-devel] [PATCH v5 0/4] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port Knut Omang
2017-07-22 7:49 ` [Qemu-devel] [PATCH v5 1/4] tests: Add test-listen - a stress test for QEMU socket listen Knut Omang
2017-07-22 7:49 ` [Qemu-devel] [PATCH v5 2/4] sockets: factor out create_fast_reuse_socket Knut Omang
2017-07-25 9:38 ` Daniel P. Berrange
2017-07-29 20:24 ` Knut Omang
2017-07-22 7:49 ` [Qemu-devel] [PATCH v5 3/4] sockets: factor out a new try_bind() function Knut Omang
2017-07-25 9:39 ` Daniel P. Berrange [this message]
2017-07-22 7:49 ` [Qemu-devel] [PATCH v5 4/4] sockets: Handle race condition between binds to the same port Knut Omang
2017-07-25 9:54 ` Daniel P. Berrange
2017-07-29 20:24 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725093921.GK26394@redhat.com \
--to=berrange@redhat.com \
--cc=knut.omang@oracle.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.