From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Ryan Kennedy <ryan5544@gmail.com>,
linux-acpi@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH] ACPI / watchdog: Fix init failure with overlapping register regions
Date: Tue, 25 Jul 2017 16:13:41 +0300 [thread overview]
Message-ID: <20170725131341.GU2369@lahna.fi.intel.com> (raw)
In-Reply-To: <20170725093731.GE2369@lahna.fi.intel.com>
On Tue, Jul 25, 2017 at 12:37:31PM +0300, Mika Westerberg wrote:
> I wonder why we need to do this?
>
> + if (res.start < rentry->res->start)
> + rentry->res->start = res.start;
> + if (res.end > rentry->res->end)
> + rentry->res->end = res.end;
>
> IIRC we don't use rentry for anything else when we go out of the loop.
> Tuning those limits seems unnecessary.
OK, Ryan pointed out that the later code then uses the adjusted rentry
so this is indeed needed.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-07-25 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 21:48 [PATCH] ACPI / watchdog: Fix init failure with overlapping register regions Ryan Kennedy
2017-07-24 20:37 ` Rafael J. Wysocki
2017-07-25 9:37 ` Mika Westerberg
2017-07-25 13:13 ` Mika Westerberg [this message]
2017-07-26 18:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725131341.GU2369@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=ryan5544@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.