From: "Lukáš Doktor" <ldoktor@redhat.com>
To: qemu-devel@nongnu.org
Cc: ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com,
apahim@redhat.com, mreitz@redhat.com, f4bug@amsat.org,
armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/10] qemu.py: Pylint/style fixes
Date: Tue, 25 Jul 2017 17:09:41 +0200 [thread overview]
Message-ID: <20170725150951.16038-1-ldoktor@redhat.com> (raw)
Hello guys,
I'm reading the available python modules to exercise qemu and while reading them
I fixed some issues that caught my attention. It usually starts with a simple
pylint/docstring fixes and slowly graduates to more controversial ones so I'm
open to suggestion to remove some of them.
Kind regards,
Lukáš
Changes v1->v2
- Squashed 2nd and 10th patches into 2nd one
- Use repr() in MonitorResponseError's description
- Improved commit message of the 6th patch
- Two tweaks to docstrings changed in the 6th patch
- Also updated qmp-shell to use new-style super calls (7th patch)
- Fixed the accidental rename of qmp `cmd_id` (kept the id->cmd_id patch)
- Changed the style of the style-fix in the 10th commit
Lukáš Doktor (10):
qemu.py: Pylint/style fixes
qemu|qtest: Avoid dangerous arguments
qemu.py: Use iteritems rather than keys()
qemu.py: Simplify QMP key-conversion
qemu.py: Use custom exceptions rather than Exception
qmp.py: Couple of pylint/style fixes
qmp.py: Use object-based class for QEMUMonitorProtocol
qmp.py: Avoid "has_key" usage
qmp.py: Avoid overriding a builtin object
qtest.py: Few pylint/style fixes
scripts/qemu.py | 98 +++++++++++++++++++++++++++++++++++++--------------
scripts/qmp/qmp-shell | 4 +--
scripts/qmp/qmp.py | 49 ++++++++++++++++----------
scripts/qtest.py | 13 ++++---
4 files changed, 109 insertions(+), 55 deletions(-)
--
2.9.4
next reply other threads:[~2017-07-25 15:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:09 Lukáš Doktor [this message]
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 01/10] qemu.py: Pylint/style fixes Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 02/10] qemu|qtest: Avoid dangerous arguments Lukáš Doktor
2017-07-25 17:14 ` John Snow
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 03/10] qemu.py: Use iteritems rather than keys() Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 04/10] qemu.py: Simplify QMP key-conversion Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-07-25 16:06 ` Eduardo Habkost
2017-07-26 4:39 ` Lukáš Doktor
2017-07-26 13:00 ` Eduardo Habkost
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 06/10] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-07-25 15:18 ` Philippe Mathieu-Daudé
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 08/10] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-07-25 19:34 ` Eduardo Habkost
2017-07-26 4:46 ` Lukáš Doktor
2017-07-26 13:01 ` Eduardo Habkost
2017-07-25 15:09 ` [Qemu-devel] [PATCH v2 10/10] qtest.py: Few pylint/style fixes Lukáš Doktor
2017-07-25 17:19 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725150951.16038-1-ldoktor@redhat.com \
--to=ldoktor@redhat.com \
--cc=apahim@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.