From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 4/6] monitor: Print space after semicolon
Date: Tue, 25 Jul 2017 18:03:08 +0200 [thread overview]
Message-ID: <20170725160308.GE591@salvia> (raw)
In-Reply-To: <20170725145629.20974-5-phil@nwl.cc>
On Tue, Jul 25, 2017 at 04:56:27PM +0200, Phil Sutter wrote:
> This makes output a bit more readable.
Could you print an example in the patch description of what is being
more readable after this? Thanks!
[...]
> diff --git a/src/rule.c b/src/rule.c
> index 5ea4fce546e30..12714ed3ccc70 100644
> --- a/src/rule.c
> +++ b/src/rule.c
> @@ -381,7 +381,7 @@ void set_print_plain(const struct set *s, struct output_ctx *octx)
> .nl = " ",
> .table = s->handle.table,
> .family = family2str(s->handle.family),
> - .stmt_separator = ";",
> + .stmt_separator = "; ",
> };
>
> do_set_print(s, &opts, octx);
> --
> 2.13.1
>
next prev parent reply other threads:[~2017-07-25 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 14:56 [nft PATCH 0/6] monitor: Some fixes and improvements Phil Sutter
2017-07-25 14:56 ` [nft PATCH 1/6] tests/monitor: Ignore newgen messages in output Phil Sutter
2017-07-25 15:57 ` Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 2/6] monitor: Fix printing of set declarations Phil Sutter
2017-07-25 15:57 ` Pablo Neira Ayuso
2017-07-25 17:09 ` Phil Sutter
2017-07-26 11:18 ` Pablo Neira Ayuso
2017-07-26 13:19 ` Phil Sutter
2017-07-25 14:56 ` [nft PATCH 3/6] tests/monitor: Simplify testcases Phil Sutter
2017-07-25 16:02 ` Pablo Neira Ayuso
2017-07-25 16:12 ` Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 4/6] monitor: Print space after semicolon Phil Sutter
2017-07-25 16:03 ` Pablo Neira Ayuso [this message]
2017-07-25 14:56 ` [nft PATCH 5/6] tests/monitor: Clear ruleset after testing Phil Sutter
2017-07-25 16:03 ` Pablo Neira Ayuso
2017-07-25 14:56 ` [nft PATCH 6/6] tests/monitor: Add a small README Phil Sutter
2017-07-25 16:18 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170725160308.GE591@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.