From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 04/11] ASoC: samsung: i2s: Handle return value of clk_prepare_enable. Date: Tue, 25 Jul 2017 19:58:35 +0200 Message-ID: <20170725175835.GC8329@kozik-book> References: <1500977674-27960-1-git-send-email-arvind.yadav.cs@gmail.com> <1500977674-27960-5-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yw0-f193.google.com (mail-yw0-f193.google.com [209.85.161.193]) by alsa0.perex.cz (Postfix) with ESMTP id 6F1B2266CFE for ; Tue, 25 Jul 2017 19:58:42 +0200 (CEST) Received: by mail-yw0-f193.google.com with SMTP id l82so3775915ywc.2 for ; Tue, 25 Jul 2017 10:58:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1500977674-27960-5-git-send-email-arvind.yadav.cs@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Arvind Yadav Cc: alsa-devel@alsa-project.org, sbkim73@samsung.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Tue, Jul 25, 2017 at 03:44:31PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/i2s.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbdGYR6n (ORCPT ); Tue, 25 Jul 2017 13:58:43 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:38877 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbdGYR6m (ORCPT ); Tue, 25 Jul 2017 13:58:42 -0400 Date: Tue, 25 Jul 2017 19:58:35 +0200 From: Krzysztof Kozlowski To: Arvind Yadav Cc: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, sbkim73@samsung.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] ASoC: samsung: i2s: Handle return value of clk_prepare_enable. Message-ID: <20170725175835.GC8329@kozik-book> References: <1500977674-27960-1-git-send-email-arvind.yadav.cs@gmail.com> <1500977674-27960-5-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1500977674-27960-5-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2017 at 03:44:31PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/i2s.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof