From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 05/11] ASoC: samsung: spdif: Handle return value of clk_prepare_enable. Date: Tue, 25 Jul 2017 20:01:19 +0200 Message-ID: <20170725180119.GD8329@kozik-book> References: <1500977674-27960-1-git-send-email-arvind.yadav.cs@gmail.com> <1500977674-27960-6-git-send-email-arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pg0-f41.google.com (mail-pg0-f41.google.com [74.125.83.41]) by alsa0.perex.cz (Postfix) with ESMTP id 7A764266CFE for ; Tue, 25 Jul 2017 20:01:32 +0200 (CEST) Received: by mail-pg0-f41.google.com with SMTP id 125so73240735pgi.3 for ; Tue, 25 Jul 2017 11:01:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1500977674-27960-6-git-send-email-arvind.yadav.cs@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Arvind Yadav Cc: alsa-devel@alsa-project.org, sbkim73@samsung.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Tue, Jul 25, 2017 at 03:44:32PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/spdif.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbdGYSBd (ORCPT ); Tue, 25 Jul 2017 14:01:33 -0400 Received: from mail-pg0-f44.google.com ([74.125.83.44]:38683 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbdGYSBc (ORCPT ); Tue, 25 Jul 2017 14:01:32 -0400 Date: Tue, 25 Jul 2017 20:01:19 +0200 From: Krzysztof Kozlowski To: Arvind Yadav Cc: perex@perex.cz, tiwai@suse.com, broonie@kernel.org, sbkim73@samsung.com, lgirdwood@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] ASoC: samsung: spdif: Handle return value of clk_prepare_enable. Message-ID: <20170725180119.GD8329@kozik-book> References: <1500977674-27960-1-git-send-email-arvind.yadav.cs@gmail.com> <1500977674-27960-6-git-send-email-arvind.yadav.cs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1500977674-27960-6-git-send-email-arvind.yadav.cs@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 25, 2017 at 03:44:32PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > sound/soc/samsung/spdif.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof