From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da5bd-0007fA-0v for qemu-devel@nongnu.org; Tue, 25 Jul 2017 15:34:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da5bY-0006li-6F for qemu-devel@nongnu.org; Tue, 25 Jul 2017 15:34:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57710) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1da5bX-0006kb-VG for qemu-devel@nongnu.org; Tue, 25 Jul 2017 15:34:52 -0400 Date: Tue, 25 Jul 2017 16:34:42 -0300 From: Eduardo Habkost Message-ID: <20170725193442.GS2757@localhost.localdomain> References: <20170725150951.16038-1-ldoktor@redhat.com> <20170725150951.16038-10-ldoktor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170725150951.16038-10-ldoktor@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?THVrw6HFoQ==?= Doktor Cc: qemu-devel@nongnu.org, famz@redhat.com, apahim@redhat.com, mreitz@redhat.com, f4bug@amsat.org, armbru@redhat.com On Tue, Jul 25, 2017 at 05:09:50PM +0200, Luk=C3=A1=C5=A1 Doktor wrote: > The "id" is a builtin method to get object's identity and should not be > overridden. This might bring some issues in case someone was directly > calling "cmd(..., id=3Did)" but I haven't found such usage on brief sea= rch > for "cmd\(.*id=3D". >=20 > Signed-off-by: Luk=C3=A1=C5=A1 Doktor I don't see the benefit of the patch, as the function is very short and unlikely to ever use the id() builtin. But I am not against it if it will silence code analyzer warnings. > --- > scripts/qmp/qmp.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py > index f2f5a9b..ef12e8a 100644 > --- a/scripts/qmp/qmp.py > +++ b/scripts/qmp/qmp.py > @@ -177,19 +177,19 @@ class QEMUMonitorProtocol(object): > print >>sys.stderr, "QMP:<<< %s" % resp > return resp > =20 > - def cmd(self, name, args=3DNone, id=3DNone): > + def cmd(self, name, args=3DNone, cmd_id=3DNone): > """ > Build a QMP command and send it to the QMP Monitor. > =20 > @param name: command name (string) > @param args: command arguments (dict) > - @param id: command id (dict, list, string or int) > + @param cmd_id: command id (dict, list, string or int) > """ > qmp_cmd =3D {'execute': name} > if args: > qmp_cmd['arguments'] =3D args > - if id: > - qmp_cmd['id'] =3D id > + if cmd_id: > + qmp_cmd['id'] =3D cmd_id > return self.cmd_obj(qmp_cmd) > =20 > def command(self, cmd, **kwds): > --=20 > 2.9.4 >=20 --=20 Eduardo