diff for duplicates of <20170726021417.GG29754@dragon> diff --git a/a/1.txt b/N1/1.txt index bffd59b..191288b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,11 @@ On Wed, Jul 19, 2017 at 04:02:45PM +0100, Martyn Welch wrote: -> From: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk> +> From: Fabien Lahoudere <fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> > > PPD is a product from GE Healthcare to monitor vital biometric signals. > -> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk> -> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> -> Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk> +> Signed-off-by: Fabien Lahoudere <fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> +> Signed-off-by: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> +> Signed-off-by: Martyn Welch <martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> > --- > > Changes since PATCHv4: https://patchwork.kernel.org/patch/9834733/ @@ -118,7 +118,7 @@ This is a board from GE instead of Freescale, right? > + stdout-path = "&uart1:115200n8"; > + }; > + -> + memory at 70000000 { +> + memory@70000000 { > + device_type = "memory"; > + reg = <0x70000000 0x20000000>, > + <0xb0000000 0x20000000>; @@ -278,7 +278,7 @@ Ditto > + }; > + }; > + -> + usbphy2: usbphy at 2 { +> + usbphy2: usbphy@2 { > + reg = <2>; The @unit-address and 'reg' property should apply to the node which has @@ -304,7 +304,7 @@ Unnecessary okay status. > + }; > + -> + usbphy3: usbphy at 3 { +> + usbphy3: usbphy@3 { > + reg = <3>; > + compatible = "usb-nop-xceiv"; > + reset-gpios = <&gpio2 19 GPIO_ACTIVE_LOW>; @@ -361,7 +361,7 @@ The property is obsolete. > + &gpio4 12 GPIO_ACTIVE_LOW>; > + status = "okay"; > + -> + spidev0: spi at 0 { +> + spidev0: spi@0 { > + compatible = "ge,achc"; > + reg = <0>; > + spi-max-frequency = <1000000>; @@ -371,7 +371,7 @@ Unnecessary okay status. > + }; > + -> + spidev1: spi at 1 { +> + spidev1: spi@1 { > + compatible = "ge,achc"; Undocumented compatible. @@ -381,7 +381,7 @@ Undocumented compatible. > + status = "okay"; > + }; > + -> + gpioxra0: gpio at 2 { +> + gpioxra0: gpio@2 { > + compatible = "exar,xra1403"; > + reg = <2>; > + gpio-controller; @@ -390,7 +390,7 @@ Undocumented compatible. > + status = "okay"; > + }; > + -> + gpioxra1: gpio at 3 { +> + gpioxra1: gpio@3 { > + compatible = "exar,xra1403"; > + reg = <3>; > + gpio-controller; @@ -411,7 +411,7 @@ How is num-chipselects used by ecspi driver? > + cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>; > + status = "okay"; > + -> + da9053 at 0 { +> + da9053@0 { > + compatible = "dlg,da9053-aa"; > + reg = <0>; > + interrupt-parent = <&gpio3>; @@ -557,7 +557,7 @@ Why do we need a disabled esdhc1 node here? > + scl-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + -> + i2xmux_pca: i2c-mux_pca954x at 70 { +> + i2xmux_pca: i2c-mux_pca954x@70 { Drop the _pca954x from node name. And the i2x in the label name looks odd. I'm actually unsure why you need a label here. @@ -568,7 +568,7 @@ odd. I'm actually unsure why you need a label here. > + #size-cells = <0>; > + reset-gpios = <&gpio2 18 GPIO_ACTIVE_LOW>; > + -> + i2c4: i2cmux-ppd at 0 { +> + i2c4: i2cmux-ppd@0 { What does 'ppd' in the node name mean? I would prefer to just name the node i2c like what the example in bindings/i2c/i2c-mux-pca954x.txt does. @@ -577,7 +577,7 @@ node i2c like what the example in bindings/i2c/i2c-mux-pca954x.txt does. > + #size-cells = <0>; > + reg = <0>; > + -> + sgtl5000: codec at 0a { +> + sgtl5000: codec@0a { Drop the leading zero in unit-address. @@ -590,17 +590,17 @@ Drop the leading zero in unit-address. > + }; > + }; > + -> + i2c5: i2cmux-ppd at 1 { +> + i2c5: i2cmux-ppd@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + -> + rtc at 30 { +> + rtc@30 { > + compatible = "sii,s35390a"; > + reg = <0x30>; > + }; > + -> + tmp112 at 48 { +> + tmp112@48 { Can we find a generic name for the node instead of using the hardware model name. @@ -612,9 +612,9 @@ Undocumented compatible. > + reg = <0x48>; > + }; > + -> + mma8453q at 1c { +> + mma8453q@1c { -mma8453q: accelerometer at 1c { +mma8453q: accelerometer@1c { > + compatible = "fsl,mma8453"; > + reg = <0x1c>; @@ -623,51 +623,51 @@ mma8453q: accelerometer at 1c { > + interrupt-names = "INT1"; > + }; > + -> + mpl3115: mpl3115 at 60 { +> + mpl3115: mpl3115@60 { -mpl3115: pressure-sensor at 60 { +mpl3115: pressure-sensor@60 { > + compatible = "fsl,mpl3115"; > + reg = <0x60>; > + }; > + -> + eeprom: eeprom at 50 { +> + eeprom: eeprom@50 { > + compatible = "atmel,24c08"; > + reg = <0x50>; > + }; > + }; > + -> + i2c6: i2cmux-ppd at 2 { +> + i2c6: i2cmux-ppd@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <2>; > + }; > + -> + i2c7: i2cmux-ppd at 3 { +> + i2c7: i2cmux-ppd@3 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <3>; > + }; > + -> + i2c8: i2cmux-ppd at 4 { +> + i2c8: i2cmux-ppd@4 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <4>; > + }; > + -> + i2c9: i2cmux-ppd at 5 { +> + i2c9: i2cmux-ppd@5 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <5>; > + }; > + -> + i2c10: i2cmux-ppd at 6 { +> + i2c10: i2cmux-ppd@6 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <6>; > + }; > + -> + i2c11: i2cmux-ppd at 7 { +> + i2c11: i2cmux-ppd@7 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <7>; @@ -683,7 +683,7 @@ mpl3115: pressure-sensor at 60 { > + scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + -> + touchscreen at 4b { +> + touchscreen@4b { > + compatible = "atmel,maxtouch"; > + reg = <0x4b>; > + interrupt-parent = <&gpio5>; @@ -703,10 +703,10 @@ mpl3115: pressure-sensor at 60 { > +&ldb { > + status = "okay"; > + -> + lvds0: lvds-channel at 0 { +> + lvds0: lvds-channel@0 { > + status = "okay"; > + -> + port at 2 { +> + port@2 { > + reg = <2>; > + > + lvds0_out: endpoint { @@ -1231,4 +1231,8 @@ Shawn > +}; > -- > 1.8.3.1 -> +> +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index f9b3ed1..7af578f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,29 @@ "ref\01500476565-3714-1-git-send-email-martyn.welch@collabora.co.uk\0" - "From\0shawnguo@kernel.org (Shawn Guo)\0" - "Subject\0[PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD\0" + "ref\01500476565-3714-1-git-send-email-martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org\0" + "From\0Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" + "Subject\0Re: [PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD\0" "Date\0Wed, 26 Jul 2017 10:14:20 +0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Martyn Welch <martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>\0" + "Cc\0Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>" + Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> + Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> + Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> + Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org> + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + Fabien Lahoudere <fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> + " Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>\0" "\00:1\0" "b\0" "On Wed, Jul 19, 2017 at 04:02:45PM +0100, Martyn Welch wrote:\n" - "> From: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>\n" + "> From: Fabien Lahoudere <fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>\n" "> \n" "> PPD is a product from GE Healthcare to monitor vital biometric signals.\n" "> \n" - "> Signed-off-by: Fabien Lahoudere <fabien.lahoudere@collabora.co.uk>\n" - "> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>\n" - "> Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>\n" + "> Signed-off-by: Fabien Lahoudere <fabien.lahoudere-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>\n" + "> Signed-off-by: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>\n" + "> Signed-off-by: Martyn Welch <martyn.welch-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>\n" "> ---\n" "> \n" "> Changes since PATCHv4: https://patchwork.kernel.org/patch/9834733/\n" @@ -125,7 +136,7 @@ "> +\t\tstdout-path = \"&uart1:115200n8\";\n" "> +\t};\n" "> +\n" - "> +\tmemory at 70000000 {\n" + "> +\tmemory@70000000 {\n" "> +\t\tdevice_type = \"memory\";\n" "> +\t\treg = <0x70000000 0x20000000>,\n" "> +\t\t <0xb0000000 0x20000000>;\n" @@ -285,7 +296,7 @@ "> +\t\t};\n" "> +\t};\n" "> +\n" - "> +\tusbphy2: usbphy at 2 {\n" + "> +\tusbphy2: usbphy@2 {\n" "> +\t\treg = <2>;\n" "\n" "The @unit-address and 'reg' property should apply to the node which has\n" @@ -311,7 +322,7 @@ "\n" "> +\t};\n" "> +\n" - "> +\tusbphy3: usbphy at 3 {\n" + "> +\tusbphy3: usbphy@3 {\n" "> +\t\treg = <3>;\n" "> +\t\tcompatible = \"usb-nop-xceiv\";\n" "> +\t\treset-gpios = <&gpio2 19 GPIO_ACTIVE_LOW>;\n" @@ -368,7 +379,7 @@ "> +\t\t &gpio4 12 GPIO_ACTIVE_LOW>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tspidev0: spi at 0 {\n" + "> +\tspidev0: spi@0 {\n" "> +\t\tcompatible = \"ge,achc\";\n" "> +\t\treg = <0>;\n" "> +\t\tspi-max-frequency = <1000000>;\n" @@ -378,7 +389,7 @@ "\n" "> +\t};\n" "> +\n" - "> +\tspidev1: spi at 1 {\n" + "> +\tspidev1: spi@1 {\n" "> +\t\tcompatible = \"ge,achc\";\n" "\n" "Undocumented compatible.\n" @@ -388,7 +399,7 @@ "> +\t\tstatus = \"okay\";\n" "> +\t};\n" "> +\n" - "> +\tgpioxra0: gpio at 2 {\n" + "> +\tgpioxra0: gpio@2 {\n" "> +\t\tcompatible = \"exar,xra1403\";\n" "> +\t\treg = <2>;\n" "> +\t\tgpio-controller;\n" @@ -397,7 +408,7 @@ "> +\t\tstatus = \"okay\";\n" "> +\t};\n" "> +\n" - "> +\tgpioxra1: gpio at 3 {\n" + "> +\tgpioxra1: gpio@3 {\n" "> +\t\tcompatible = \"exar,xra1403\";\n" "> +\t\treg = <3>;\n" "> +\t\tgpio-controller;\n" @@ -418,7 +429,7 @@ "> +\tcs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tda9053 at 0 {\n" + "> +\tda9053@0 {\n" "> +\t\tcompatible = \"dlg,da9053-aa\";\n" "> +\t\treg = <0>;\n" "> +\t\tinterrupt-parent = <&gpio3>;\n" @@ -564,7 +575,7 @@ "> +\tscl-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\ti2xmux_pca: i2c-mux_pca954x at 70 {\n" + "> +\ti2xmux_pca: i2c-mux_pca954x@70 {\n" "\n" "Drop the _pca954x from node name. And the i2x in the label name looks\n" "odd. I'm actually unsure why you need a label here.\n" @@ -575,7 +586,7 @@ "> +\t\t#size-cells = <0>;\n" "> +\t\treset-gpios = <&gpio2 18 GPIO_ACTIVE_LOW>;\n" "> +\n" - "> +\t\ti2c4: i2cmux-ppd at 0 {\n" + "> +\t\ti2c4: i2cmux-ppd@0 {\n" "\n" "What does 'ppd' in the node name mean? I would prefer to just name the\n" "node i2c like what the example in bindings/i2c/i2c-mux-pca954x.txt does.\n" @@ -584,7 +595,7 @@ "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <0>;\n" "> +\n" - "> +\t\t\tsgtl5000: codec at 0a {\n" + "> +\t\t\tsgtl5000: codec@0a {\n" "\n" "Drop the leading zero in unit-address.\n" "\n" @@ -597,17 +608,17 @@ "> +\t\t\t};\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c5: i2cmux-ppd at 1 {\n" + "> +\t\ti2c5: i2cmux-ppd@1 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <1>;\n" "> +\n" - "> +\t\t\trtc at 30 {\n" + "> +\t\t\trtc@30 {\n" "> +\t\t\t compatible = \"sii,s35390a\";\n" "> +\t\t\t reg = <0x30>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\ttmp112 at 48 {\n" + "> +\t\t\ttmp112@48 {\n" "\n" "Can we find a generic name for the node instead of using the hardware\n" "model name.\n" @@ -619,9 +630,9 @@ "> +\t\t\t\treg = <0x48>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\tmma8453q at 1c {\n" + "> +\t\t\tmma8453q@1c {\n" "\n" - "mma8453q: accelerometer at 1c {\n" + "mma8453q: accelerometer@1c {\n" "\n" "> +\t\t\t\tcompatible = \"fsl,mma8453\";\n" "> +\t\t\t\treg = <0x1c>;\n" @@ -630,51 +641,51 @@ "> +\t\t\t\tinterrupt-names = \"INT1\";\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\tmpl3115: mpl3115 at 60 {\n" + "> +\t\t\tmpl3115: mpl3115@60 {\n" "\n" - "mpl3115: pressure-sensor at 60 {\n" + "mpl3115: pressure-sensor@60 {\n" "\n" "> +\t\t\t\tcompatible = \"fsl,mpl3115\";\n" "> +\t\t\t\treg = <0x60>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\teeprom: eeprom at 50 {\n" + "> +\t\t\teeprom: eeprom@50 {\n" "> +\t\t\t\tcompatible = \"atmel,24c08\";\n" "> +\t\t\t\treg = <0x50>;\n" "> +\t\t\t};\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c6: i2cmux-ppd at 2 {\n" + "> +\t\ti2c6: i2cmux-ppd@2 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <2>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c7: i2cmux-ppd at 3 {\n" + "> +\t\ti2c7: i2cmux-ppd@3 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <3>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c8: i2cmux-ppd at 4 {\n" + "> +\t\ti2c8: i2cmux-ppd@4 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <4>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c9: i2cmux-ppd at 5 {\n" + "> +\t\ti2c9: i2cmux-ppd@5 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <5>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c10: i2cmux-ppd at 6 {\n" + "> +\t\ti2c10: i2cmux-ppd@6 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <6>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c11: i2cmux-ppd at 7 {\n" + "> +\t\ti2c11: i2cmux-ppd@7 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <7>;\n" @@ -690,7 +701,7 @@ "> +\tscl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\ttouchscreen at 4b {\n" + "> +\ttouchscreen@4b {\n" "> +\t\tcompatible = \"atmel,maxtouch\";\n" "> +\t\treg = <0x4b>;\n" "> +\t\tinterrupt-parent = <&gpio5>;\n" @@ -710,10 +721,10 @@ "> +&ldb {\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tlvds0: lvds-channel at 0 {\n" + "> +\tlvds0: lvds-channel@0 {\n" "> +\t\tstatus = \"okay\";\n" "> +\n" - "> +\t\tport at 2 {\n" + "> +\t\tport@2 {\n" "> +\t\t\treg = <2>;\n" "> +\n" "> +\t\t\tlvds0_out: endpoint {\n" @@ -1238,6 +1249,10 @@ "> +};\n" "> -- \n" "> 1.8.3.1\n" - > + "> \n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -d32ad57178cf9d5ce737e00347e521d99a5e2308383697e3fef0c403afd4a51d +e745e666f1e4fbee1116873dd968ba7caf876e55620b02c41bfa017b9aad842a
diff --git a/a/1.txt b/N2/1.txt index bffd59b..acea260 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -118,7 +118,7 @@ This is a board from GE instead of Freescale, right? > + stdout-path = "&uart1:115200n8"; > + }; > + -> + memory at 70000000 { +> + memory@70000000 { > + device_type = "memory"; > + reg = <0x70000000 0x20000000>, > + <0xb0000000 0x20000000>; @@ -278,7 +278,7 @@ Ditto > + }; > + }; > + -> + usbphy2: usbphy at 2 { +> + usbphy2: usbphy@2 { > + reg = <2>; The @unit-address and 'reg' property should apply to the node which has @@ -304,7 +304,7 @@ Unnecessary okay status. > + }; > + -> + usbphy3: usbphy at 3 { +> + usbphy3: usbphy@3 { > + reg = <3>; > + compatible = "usb-nop-xceiv"; > + reset-gpios = <&gpio2 19 GPIO_ACTIVE_LOW>; @@ -361,7 +361,7 @@ The property is obsolete. > + &gpio4 12 GPIO_ACTIVE_LOW>; > + status = "okay"; > + -> + spidev0: spi at 0 { +> + spidev0: spi@0 { > + compatible = "ge,achc"; > + reg = <0>; > + spi-max-frequency = <1000000>; @@ -371,7 +371,7 @@ Unnecessary okay status. > + }; > + -> + spidev1: spi at 1 { +> + spidev1: spi@1 { > + compatible = "ge,achc"; Undocumented compatible. @@ -381,7 +381,7 @@ Undocumented compatible. > + status = "okay"; > + }; > + -> + gpioxra0: gpio at 2 { +> + gpioxra0: gpio@2 { > + compatible = "exar,xra1403"; > + reg = <2>; > + gpio-controller; @@ -390,7 +390,7 @@ Undocumented compatible. > + status = "okay"; > + }; > + -> + gpioxra1: gpio at 3 { +> + gpioxra1: gpio@3 { > + compatible = "exar,xra1403"; > + reg = <3>; > + gpio-controller; @@ -411,7 +411,7 @@ How is num-chipselects used by ecspi driver? > + cs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>; > + status = "okay"; > + -> + da9053 at 0 { +> + da9053@0 { > + compatible = "dlg,da9053-aa"; > + reg = <0>; > + interrupt-parent = <&gpio3>; @@ -557,7 +557,7 @@ Why do we need a disabled esdhc1 node here? > + scl-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + -> + i2xmux_pca: i2c-mux_pca954x at 70 { +> + i2xmux_pca: i2c-mux_pca954x@70 { Drop the _pca954x from node name. And the i2x in the label name looks odd. I'm actually unsure why you need a label here. @@ -568,7 +568,7 @@ odd. I'm actually unsure why you need a label here. > + #size-cells = <0>; > + reset-gpios = <&gpio2 18 GPIO_ACTIVE_LOW>; > + -> + i2c4: i2cmux-ppd at 0 { +> + i2c4: i2cmux-ppd@0 { What does 'ppd' in the node name mean? I would prefer to just name the node i2c like what the example in bindings/i2c/i2c-mux-pca954x.txt does. @@ -577,7 +577,7 @@ node i2c like what the example in bindings/i2c/i2c-mux-pca954x.txt does. > + #size-cells = <0>; > + reg = <0>; > + -> + sgtl5000: codec at 0a { +> + sgtl5000: codec@0a { Drop the leading zero in unit-address. @@ -590,17 +590,17 @@ Drop the leading zero in unit-address. > + }; > + }; > + -> + i2c5: i2cmux-ppd at 1 { +> + i2c5: i2cmux-ppd@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + -> + rtc at 30 { +> + rtc@30 { > + compatible = "sii,s35390a"; > + reg = <0x30>; > + }; > + -> + tmp112 at 48 { +> + tmp112@48 { Can we find a generic name for the node instead of using the hardware model name. @@ -612,9 +612,9 @@ Undocumented compatible. > + reg = <0x48>; > + }; > + -> + mma8453q at 1c { +> + mma8453q@1c { -mma8453q: accelerometer at 1c { +mma8453q: accelerometer@1c { > + compatible = "fsl,mma8453"; > + reg = <0x1c>; @@ -623,51 +623,51 @@ mma8453q: accelerometer at 1c { > + interrupt-names = "INT1"; > + }; > + -> + mpl3115: mpl3115 at 60 { +> + mpl3115: mpl3115@60 { -mpl3115: pressure-sensor at 60 { +mpl3115: pressure-sensor@60 { > + compatible = "fsl,mpl3115"; > + reg = <0x60>; > + }; > + -> + eeprom: eeprom at 50 { +> + eeprom: eeprom@50 { > + compatible = "atmel,24c08"; > + reg = <0x50>; > + }; > + }; > + -> + i2c6: i2cmux-ppd at 2 { +> + i2c6: i2cmux-ppd@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <2>; > + }; > + -> + i2c7: i2cmux-ppd at 3 { +> + i2c7: i2cmux-ppd@3 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <3>; > + }; > + -> + i2c8: i2cmux-ppd at 4 { +> + i2c8: i2cmux-ppd@4 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <4>; > + }; > + -> + i2c9: i2cmux-ppd at 5 { +> + i2c9: i2cmux-ppd@5 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <5>; > + }; > + -> + i2c10: i2cmux-ppd at 6 { +> + i2c10: i2cmux-ppd@6 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <6>; > + }; > + -> + i2c11: i2cmux-ppd at 7 { +> + i2c11: i2cmux-ppd@7 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <7>; @@ -683,7 +683,7 @@ mpl3115: pressure-sensor at 60 { > + scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + -> + touchscreen at 4b { +> + touchscreen@4b { > + compatible = "atmel,maxtouch"; > + reg = <0x4b>; > + interrupt-parent = <&gpio5>; @@ -703,10 +703,10 @@ mpl3115: pressure-sensor at 60 { > +&ldb { > + status = "okay"; > + -> + lvds0: lvds-channel at 0 { +> + lvds0: lvds-channel@0 { > + status = "okay"; > + -> + port at 2 { +> + port@2 { > + reg = <2>; > + > + lvds0_out: endpoint { diff --git a/a/content_digest b/N2/content_digest index f9b3ed1..2c1bb78 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,18 @@ "ref\01500476565-3714-1-git-send-email-martyn.welch@collabora.co.uk\0" - "From\0shawnguo@kernel.org (Shawn Guo)\0" - "Subject\0[PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD\0" + "From\0Shawn Guo <shawnguo@kernel.org>\0" + "Subject\0Re: [PATCH v5] ARM: dts: imx53: Add GE Healthcare PPD\0" "Date\0Wed, 26 Jul 2017 10:14:20 +0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Martyn Welch <martyn.welch@collabora.co.uk>\0" + "Cc\0Sebastian Reichel <sre@kernel.org>" + Rob Herring <robh+dt@kernel.org> + Mark Rutland <mark.rutland@arm.com> + Sascha Hauer <kernel@pengutronix.de> + Fabio Estevam <fabio.estevam@nxp.com> + devicetree@vger.kernel.org + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + Fabien Lahoudere <fabien.lahoudere@collabora.co.uk> + " Sebastian Reichel <sebastian.reichel@collabora.co.uk>\0" "\00:1\0" "b\0" "On Wed, Jul 19, 2017 at 04:02:45PM +0100, Martyn Welch wrote:\n" @@ -125,7 +135,7 @@ "> +\t\tstdout-path = \"&uart1:115200n8\";\n" "> +\t};\n" "> +\n" - "> +\tmemory at 70000000 {\n" + "> +\tmemory@70000000 {\n" "> +\t\tdevice_type = \"memory\";\n" "> +\t\treg = <0x70000000 0x20000000>,\n" "> +\t\t <0xb0000000 0x20000000>;\n" @@ -285,7 +295,7 @@ "> +\t\t};\n" "> +\t};\n" "> +\n" - "> +\tusbphy2: usbphy at 2 {\n" + "> +\tusbphy2: usbphy@2 {\n" "> +\t\treg = <2>;\n" "\n" "The @unit-address and 'reg' property should apply to the node which has\n" @@ -311,7 +321,7 @@ "\n" "> +\t};\n" "> +\n" - "> +\tusbphy3: usbphy at 3 {\n" + "> +\tusbphy3: usbphy@3 {\n" "> +\t\treg = <3>;\n" "> +\t\tcompatible = \"usb-nop-xceiv\";\n" "> +\t\treset-gpios = <&gpio2 19 GPIO_ACTIVE_LOW>;\n" @@ -368,7 +378,7 @@ "> +\t\t &gpio4 12 GPIO_ACTIVE_LOW>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tspidev0: spi at 0 {\n" + "> +\tspidev0: spi@0 {\n" "> +\t\tcompatible = \"ge,achc\";\n" "> +\t\treg = <0>;\n" "> +\t\tspi-max-frequency = <1000000>;\n" @@ -378,7 +388,7 @@ "\n" "> +\t};\n" "> +\n" - "> +\tspidev1: spi at 1 {\n" + "> +\tspidev1: spi@1 {\n" "> +\t\tcompatible = \"ge,achc\";\n" "\n" "Undocumented compatible.\n" @@ -388,7 +398,7 @@ "> +\t\tstatus = \"okay\";\n" "> +\t};\n" "> +\n" - "> +\tgpioxra0: gpio at 2 {\n" + "> +\tgpioxra0: gpio@2 {\n" "> +\t\tcompatible = \"exar,xra1403\";\n" "> +\t\treg = <2>;\n" "> +\t\tgpio-controller;\n" @@ -397,7 +407,7 @@ "> +\t\tstatus = \"okay\";\n" "> +\t};\n" "> +\n" - "> +\tgpioxra1: gpio at 3 {\n" + "> +\tgpioxra1: gpio@3 {\n" "> +\t\tcompatible = \"exar,xra1403\";\n" "> +\t\treg = <3>;\n" "> +\t\tgpio-controller;\n" @@ -418,7 +428,7 @@ "> +\tcs-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tda9053 at 0 {\n" + "> +\tda9053@0 {\n" "> +\t\tcompatible = \"dlg,da9053-aa\";\n" "> +\t\treg = <0>;\n" "> +\t\tinterrupt-parent = <&gpio3>;\n" @@ -564,7 +574,7 @@ "> +\tscl-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\ti2xmux_pca: i2c-mux_pca954x at 70 {\n" + "> +\ti2xmux_pca: i2c-mux_pca954x@70 {\n" "\n" "Drop the _pca954x from node name. And the i2x in the label name looks\n" "odd. I'm actually unsure why you need a label here.\n" @@ -575,7 +585,7 @@ "> +\t\t#size-cells = <0>;\n" "> +\t\treset-gpios = <&gpio2 18 GPIO_ACTIVE_LOW>;\n" "> +\n" - "> +\t\ti2c4: i2cmux-ppd at 0 {\n" + "> +\t\ti2c4: i2cmux-ppd@0 {\n" "\n" "What does 'ppd' in the node name mean? I would prefer to just name the\n" "node i2c like what the example in bindings/i2c/i2c-mux-pca954x.txt does.\n" @@ -584,7 +594,7 @@ "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <0>;\n" "> +\n" - "> +\t\t\tsgtl5000: codec at 0a {\n" + "> +\t\t\tsgtl5000: codec@0a {\n" "\n" "Drop the leading zero in unit-address.\n" "\n" @@ -597,17 +607,17 @@ "> +\t\t\t};\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c5: i2cmux-ppd at 1 {\n" + "> +\t\ti2c5: i2cmux-ppd@1 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <1>;\n" "> +\n" - "> +\t\t\trtc at 30 {\n" + "> +\t\t\trtc@30 {\n" "> +\t\t\t compatible = \"sii,s35390a\";\n" "> +\t\t\t reg = <0x30>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\ttmp112 at 48 {\n" + "> +\t\t\ttmp112@48 {\n" "\n" "Can we find a generic name for the node instead of using the hardware\n" "model name.\n" @@ -619,9 +629,9 @@ "> +\t\t\t\treg = <0x48>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\tmma8453q at 1c {\n" + "> +\t\t\tmma8453q@1c {\n" "\n" - "mma8453q: accelerometer at 1c {\n" + "mma8453q: accelerometer@1c {\n" "\n" "> +\t\t\t\tcompatible = \"fsl,mma8453\";\n" "> +\t\t\t\treg = <0x1c>;\n" @@ -630,51 +640,51 @@ "> +\t\t\t\tinterrupt-names = \"INT1\";\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\tmpl3115: mpl3115 at 60 {\n" + "> +\t\t\tmpl3115: mpl3115@60 {\n" "\n" - "mpl3115: pressure-sensor at 60 {\n" + "mpl3115: pressure-sensor@60 {\n" "\n" "> +\t\t\t\tcompatible = \"fsl,mpl3115\";\n" "> +\t\t\t\treg = <0x60>;\n" "> +\t\t\t};\n" "> +\n" - "> +\t\t\teeprom: eeprom at 50 {\n" + "> +\t\t\teeprom: eeprom@50 {\n" "> +\t\t\t\tcompatible = \"atmel,24c08\";\n" "> +\t\t\t\treg = <0x50>;\n" "> +\t\t\t};\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c6: i2cmux-ppd at 2 {\n" + "> +\t\ti2c6: i2cmux-ppd@2 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <2>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c7: i2cmux-ppd at 3 {\n" + "> +\t\ti2c7: i2cmux-ppd@3 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <3>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c8: i2cmux-ppd at 4 {\n" + "> +\t\ti2c8: i2cmux-ppd@4 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <4>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c9: i2cmux-ppd at 5 {\n" + "> +\t\ti2c9: i2cmux-ppd@5 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <5>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c10: i2cmux-ppd at 6 {\n" + "> +\t\ti2c10: i2cmux-ppd@6 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <6>;\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c11: i2cmux-ppd at 7 {\n" + "> +\t\ti2c11: i2cmux-ppd@7 {\n" "> +\t\t\t#address-cells = <1>;\n" "> +\t\t\t#size-cells = <0>;\n" "> +\t\t\treg = <7>;\n" @@ -690,7 +700,7 @@ "> +\tscl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\ttouchscreen at 4b {\n" + "> +\ttouchscreen@4b {\n" "> +\t\tcompatible = \"atmel,maxtouch\";\n" "> +\t\treg = <0x4b>;\n" "> +\t\tinterrupt-parent = <&gpio5>;\n" @@ -710,10 +720,10 @@ "> +&ldb {\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tlvds0: lvds-channel at 0 {\n" + "> +\tlvds0: lvds-channel@0 {\n" "> +\t\tstatus = \"okay\";\n" "> +\n" - "> +\t\tport at 2 {\n" + "> +\t\tport@2 {\n" "> +\t\t\treg = <2>;\n" "> +\n" "> +\t\t\tlvds0_out: endpoint {\n" @@ -1240,4 +1250,4 @@ "> 1.8.3.1\n" > -d32ad57178cf9d5ce737e00347e521d99a5e2308383697e3fef0c403afd4a51d +572c33a29d4c73931bb329658e0d4b1bc452ac6d36ef1f9be837502c4f520231
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.