From: Joerg Roedel <joro@8bytes.org>
To: Tomasz Figa <tfiga@chromium.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v2 1/2] iommu/dma: Respect __GFP_DMA and __GFP_DMA32 in incoming GFP flags
Date: Wed, 26 Jul 2017 11:15:46 +0200 [thread overview]
Message-ID: <20170726091545.GC15833@8bytes.org> (raw)
In-Reply-To: <20170704135556.21704-1-tfiga@chromium.org>
On Tue, Jul 04, 2017 at 10:55:55PM +0900, Tomasz Figa wrote:
> Current implementation of __iommu_dma_alloc_pages() keeps adding
> __GFP_HIGHMEM to GFP flags regardless of whether other zone flags are
> already included in the incoming flags. If __GFP_DMA or __GFP_DMA32 is
> set at the same time as __GFP_HIGHMEM, the allocation fails due to
> invalid zone flag combination.
>
> Fix this by checking for __GFP_DMA and __GFP_DMA32 in incoming GFP flags
> and adding __GFP_HIGHMEM only if they are not present.
>
> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
Isn't it better to mask out __GFP_DMA and __GFP_DMA32 in the allocation
flags and only take them into account for iova allocation?
When the IOMMU re-maps the DMA to this memory it doesn't matter where it
is in system memory.
Joerg
next prev parent reply other threads:[~2017-07-26 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 13:55 [PATCH v2 1/2] iommu/dma: Respect __GFP_DMA and __GFP_DMA32 in incoming GFP flags Tomasz Figa
2017-07-04 13:55 ` Tomasz Figa
[not found] ` <20170704135556.21704-1-tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2017-07-04 13:55 ` [PATCH v2 2/2] iommu/dma: Use __GFP_NOWARN only for high-order allocations Tomasz Figa
2017-07-04 13:55 ` Tomasz Figa
2017-07-26 9:24 ` Joerg Roedel
[not found] ` <20170726092411.GD15833-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-07-26 9:29 ` Tomasz Figa
2017-07-26 9:29 ` Tomasz Figa
2017-07-26 9:15 ` Joerg Roedel [this message]
[not found] ` <20170726091545.GC15833-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-07-26 9:26 ` [PATCH v2 1/2] iommu/dma: Respect __GFP_DMA and __GFP_DMA32 in incoming GFP flags Tomasz Figa
2017-07-26 9:26 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726091545.GC15833@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.