From: Florian Westphal <fw@strlen.de>
To: Taehee Yoo <ap420073@gmail.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH V2] netfilter: x_tables: Fix use-after-free in ipt_do_table.
Date: Wed, 26 Jul 2017 11:27:16 +0200 [thread overview]
Message-ID: <20170726092716.GB28392@breakpoint.cc> (raw)
In-Reply-To: <20170726091648.20639-1-ap420073@gmail.com>
Taehee Yoo <ap420073@gmail.com> wrote:
> If verdict is NF_STOLEN in the SYNPROXY target,
> the skb is consumed.
> However, ipt_do_table() always tries to get ip header from the skb.
> So that, KASAN triggers the use-after-free message.
In case anyone wonders, ip6tables doesn't have this problem
because we pass *skb, not ip6hdr to ip6_packet_match().
arptables has the same bug, it seems (no target returns STOLEN,
but I think we should fix it there as well).
next prev parent reply other threads:[~2017-07-26 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 9:16 [PATCH V2] netfilter: x_tables: Fix use-after-free in ipt_do_table Taehee Yoo
2017-07-26 9:27 ` Florian Westphal [this message]
2017-07-26 11:06 ` Pablo Neira Ayuso
2017-07-27 1:12 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726092716.GB28392@breakpoint.cc \
--to=fw@strlen.de \
--cc=ap420073@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.