From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daJfr-0001AU-Jd for qemu-devel@nongnu.org; Wed, 26 Jul 2017 06:36:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daJfn-0000P3-RB for qemu-devel@nongnu.org; Wed, 26 Jul 2017 06:36:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daJfn-0000Of-Ho for qemu-devel@nongnu.org; Wed, 26 Jul 2017 06:36:11 -0400 Date: Wed, 26 Jul 2017 11:35:53 +0100 From: "Daniel P. Berrange" Message-ID: <20170726103553.GC7620@redhat.com> Reply-To: "Daniel P. Berrange" References: <1499952476-3454-1-git-send-email-armbru@redhat.com> <1499952476-3454-7-git-send-email-armbru@redhat.com> <20170717101906.GC5301@noname.redhat.com> <87a842b9yo.fsf@dusky.pond.sub.org> <87bmoauz2s.fsf@dusky.pond.sub.org> <5b194736-15ba-7f62-cc8b-46cf03777644@redhat.com> <20170725190818.GQ2757@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170725190818.GQ2757@localhost.localdomain> Subject: Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report()) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Paolo Bonzini , Peter Maydell , Cornelia Huck , Ronnie Sahlberg , "Michael S. Tsirkin" , Jeff Cody , qemu-devel@nongnu.org, Alexander Graf , Gerd Hoffmann , Rob Herring , Josh Durgin , Markus Armbruster , Christian Borntraeger , Marcel Apfelbaum , David Gibson , Jason Wang , Peter Lieven , Greg Kurz , Alistair Francis , Peter Chubb , Stefan Hajnoczi , Richard Henderson , Kevin Wolf , Peter Crosthwaite , Marcelo Tosatti , "Richard W.M. Jones" , Max Reitz , "An eesh Kumar K.V" , Igor Mammedov On Tue, Jul 25, 2017 at 04:08:18PM -0300, Eduardo Habkost wrote: > On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: > > On 24/07/2017 08:30, Markus Armbruster wrote: > > > Markus Armbruster writes: > > > > > >> Kevin Wolf writes: > > >> > > >>> Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: > > >>>> From: Alistair Francis > > >>>> > > >>>> Convert all uses of error_report("warning:"... to use warn_report() > > >>>> instead. This helps standardise on a single method of printing warnings > > >>>> to the user. > > >>>> > > >>>> All of the warnings were changed using these two commands: > > >>>> find ./* -type f -exec sed -i \ > > >>>> 's|error_report(".*warning[,:] |warn_report("|Ig' {} + > > >>>> > > >>>> Indentation fixed up manually afterwards. > > >>>> > > >>>> The test-qdev-global-props test case was manually updated to ensure that > > >>>> this patch passes make check (as the test cases are case sensitive). > > >>> > > >>> This patch broke qemu-iotests 051 because it neglected to update the > > >>> reference output. Not sure if a change of the message was even intended, > > >>> but with a error location prefix, the order changes: > > >>> > > >>> -(qemu) QEMU_PROG: -drive if=scsi,media=cdrom: warning: bus=0,unit=0 is deprecated with this machine type > > >>> +(qemu) warning: qemu-system-x86_64: -drive if=scsi,media=cdrom: bus=0,unit=0 is deprecated with this machine type > > >>> > > >>> Personally, I would expect the error location or at least the program > > >>> name to come first even for warnings. > > >> > > >> I'll fix it. > > >> > > >> While focusing on something other than block, I forget qemu-iotests > > >> exist. My fault, but it's a pretty common fault. I reiterate my plea > > >> to include (a sensible subset of) it in "make check". > > > > > > Oh, 051 isn't run by "make check-block". It could just as well not > > > exist then. > > > > > > What's the recommended way to run all iotests a build of QEMU can run? > > > > I use "path-to-srcdir/tests/check-block.sh". It takes about 20 minutes. > > > > There are two issues with check-block: > > > > * tests that require QEMU are skipped (rationale: you might be building > > without the x86_64-softmmu target). > > > > * it only runs the "quick" group, but I think we should reverse the > > direction and mark slow tests specifically (that would cut about 10 > > minutes out of the 20). > > About slow tests: I never included device-crash-test on "make > check" because it would take too long to run. Also, "make > check-help" lies when it says "make check" runs all tests, > because it doesn't run check-block. Even if you also run "check-block", it would still be a lie because you'd not be running block tests for anything other than qcow2, which is far from "all tests". Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|