From: Joerg Roedel <joro@8bytes.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: laurent.pinchart+renesas@ideasonboard.com,
geert+renesas@glider.be, robin.murphy@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
iommu@lists.linux-foundation.org, horms+renesas@verge.net.au,
sricharan@codeaurora.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v2 01/05] iommu/ipmmu-vmsa: Use iommu_device_register()/unregister()
Date: Wed, 26 Jul 2017 12:44:11 +0200 [thread overview]
Message-ID: <20170726104410.GI15833@8bytes.org> (raw)
In-Reply-To: <150029671059.22030.9200719361237858789.sendpatchset@little-apple>
On Mon, Jul 17, 2017 at 10:05:10PM +0900, Magnus Damm wrote:
> --- 0001/drivers/iommu/ipmmu-vmsa.c
> +++ work/drivers/iommu/ipmmu-vmsa.c 2017-07-17 21:01:47.140607110 +0900
> @@ -35,6 +35,7 @@
> struct ipmmu_vmsa_device {
> struct device *dev;
> void __iomem *base;
> + struct iommu_device iommu;
> struct list_head list;
>
> unsigned int num_utlbs;
> @@ -1054,6 +1055,13 @@ static int ipmmu_probe(struct platform_d
>
> ipmmu_device_reset(mmu);
>
> + iommu_device_set_ops(&mmu->iommu, &ipmmu_ops);
> + iommu_device_set_fwnode(&mmu->iommu, &pdev->dev.of_node->fwnode);
> +
> + ret = iommu_device_register(&mmu->iommu);
> + if (ret)
> + return ret;
> +
Looks good so far, why don't you also add the iommu to sysfs with
iommu_device_sysfs_add()?
Joerg
next prev parent reply other threads:[~2017-07-26 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 13:04 [PATCH v2 00/05] iommu/ipmmu-vmsa: 32-bit ARM update V2 Magnus Damm
2017-07-17 13:05 ` [PATCH v2 01/05] iommu/ipmmu-vmsa: Use iommu_device_register()/unregister() Magnus Damm
2017-07-17 13:05 ` Magnus Damm
2017-07-26 10:44 ` Joerg Roedel [this message]
2017-07-17 13:05 ` [PATCH v2 02/05] iommu/ipmmu-vmsa: Consistent ->of_xlate() handling Magnus Damm
2017-07-17 13:05 ` Magnus Damm
2017-07-17 13:05 ` [PATCH v2 03/05] iommu/ipmmu-vmsa: Use fwspec on both 32 and 64-bit ARM Magnus Damm
2017-07-17 13:05 ` Magnus Damm
2017-07-17 13:05 ` [PATCH v2 04/05] iommu/ipmmu-vmsa: Replace local utlb code with fwspec ids Magnus Damm
2017-07-17 13:05 ` [PATCH v2 05/05] iommu/ipmmu-vmsa: Clean up device tracking Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170726104410.GI15833@8bytes.org \
--to=joro@8bytes.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=iommu@lists.linux-foundation.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=magnus.damm@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sricharan@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.