From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 26 Jul 2017 13:48:12 +0200 From: Heiko Carstens Subject: Re: [PATCH] mm: take memory hotplug lock within numa_zonelist_order_handler() References: <20170726111738.38768-1-heiko.carstens@de.ibm.com> <20170726113112.GJ2981@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170726113112.GJ2981@dhcp22.suse.cz> Message-Id: <20170726114812.GH3218@osiris> Sender: owner-linux-mm@kvack.org List-Archive: List-Post: To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Wild , KAMEZAWA Hiroyuki , Thomas Gleixner , Vlastimil Babka List-ID: On Wed, Jul 26, 2017 at 01:31:12PM +0200, Michal Hocko wrote: > On Wed 26-07-17 13:17:38, Heiko Carstens wrote: > [...] > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 6d30e914afb6..fc32aa81f359 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -4891,9 +4891,11 @@ int numa_zonelist_order_handler(struct ctl_table *table, int write, > > NUMA_ZONELIST_ORDER_LEN); > > user_zonelist_order = oldval; > > } else if (oldval != user_zonelist_order) { > > + mem_hotplug_begin(); > > mutex_lock(&zonelists_mutex); > > build_all_zonelists(NULL, NULL); > > mutex_unlock(&zonelists_mutex); > > + mem_hotplug_done(); > > } > > } > > out: > > Please note that this code has been removed by > http://lkml.kernel.org/r/20170721143915.14161-2-mhocko@kernel.org. It > will get to linux-next as soon as Andrew releases a new version mmotm > tree. We still would need something for 4.13, no? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631AbdGZLsU (ORCPT ); Wed, 26 Jul 2017 07:48:20 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38735 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbdGZLsT (ORCPT ); Wed, 26 Jul 2017 07:48:19 -0400 Date: Wed, 26 Jul 2017 13:48:12 +0200 From: Heiko Carstens To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Wild , KAMEZAWA Hiroyuki , Thomas Gleixner , Vlastimil Babka Subject: Re: [PATCH] mm: take memory hotplug lock within numa_zonelist_order_handler() References: <20170726111738.38768-1-heiko.carstens@de.ibm.com> <20170726113112.GJ2981@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170726113112.GJ2981@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17072611-0012-0000-0000-000005667575 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17072611-0013-0000-0000-000018DB8BDB Message-Id: <20170726114812.GH3218@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-26_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707260167 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2017 at 01:31:12PM +0200, Michal Hocko wrote: > On Wed 26-07-17 13:17:38, Heiko Carstens wrote: > [...] > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 6d30e914afb6..fc32aa81f359 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -4891,9 +4891,11 @@ int numa_zonelist_order_handler(struct ctl_table *table, int write, > > NUMA_ZONELIST_ORDER_LEN); > > user_zonelist_order = oldval; > > } else if (oldval != user_zonelist_order) { > > + mem_hotplug_begin(); > > mutex_lock(&zonelists_mutex); > > build_all_zonelists(NULL, NULL); > > mutex_unlock(&zonelists_mutex); > > + mem_hotplug_done(); > > } > > } > > out: > > Please note that this code has been removed by > http://lkml.kernel.org/r/20170721143915.14161-2-mhocko@kernel.org. It > will get to linux-next as soon as Andrew releases a new version mmotm > tree. We still would need something for 4.13, no?