All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] package/libv4l: no libv4lconvert helper support if no fork()
Date: Wed, 26 Jul 2017 13:20:48 +0200	[thread overview]
Message-ID: <20170726132048.32bf249d@windsurf.lan> (raw)
In-Reply-To: <1501064391-32685-2-git-send-email-hugues.fruchet@st.com>

Hello,

Thanks for picking up my proposal!

On Wed, 26 Jul 2017 12:19:51 +0200, Hugues Fruchet wrote:
> Build libv4lconvert helper support only when fork()
> is available.
> This fix the build issue reported here:
> http://lists.buildroot.org/pipermail/buildroot/2017-July/197571.html

Don't use a mailing list link for references to build failures.
Instead, you should point to the appropriate build result on
http://autobuild.buildroot.org

> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I haven't Signed-off-by on this commit, so this shouldn't be there.

> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
>  ...lconvert-helper-support-only-when-fork-is.patch | 101 +++++++++++++++++++++
>  1 file changed, 101 insertions(+)
>  create mode 100644 package/libv4l/0010-Build-libv4lconvert-helper-support-only-when-fork-is.patch
> 
> diff --git a/package/libv4l/0010-Build-libv4lconvert-helper-support-only-when-fork-is.patch b/package/libv4l/0010-Build-libv4lconvert-helper-support-only-when-fork-is.patch
> new file mode 100644
> index 0000000..705dea4
> --- /dev/null
> +++ b/package/libv4l/0010-Build-libv4lconvert-helper-support-only-when-fork-is.patch
> @@ -0,0 +1,101 @@
> +From 30b3692ccb590407f35b43bbae3e3a4298cdbe52 Mon Sep 17 00:00:00 2001
> +From: Hugues Fruchet <hugues.fruchet@st.com>

If you are the author...

> +Date: Wed, 26 Jul 2017 12:17:08 +0200
> +Subject: [PATCH 10/10] Build libv4lconvert helper support only when fork() is
> + available
> +
> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>

... then you should be the first person in the Signed-off-by list. And
if you keep yourself as the author, then remove my name from the
Signed-off-by list.

Signed-off-by is used when:

 - I am the author (first Signed-off-by)

 - I am passing the patch (because I'm taking it from another project,
   or because I'm a maintainer applying the patch contributed by
   someone else)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-07-26 11:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 10:19 [Buildroot] [PATCH v1] package/libv4l: no libv4lconvert helper support if no fork() Hugues Fruchet
2017-07-26 10:19 ` Hugues Fruchet
2017-07-26 11:20   ` Thomas Petazzoni [this message]
2017-07-26 12:13     ` Hugues FRUCHET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726132048.32bf249d@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.