Re: [v2 2/3] ASoC: Intel: Fix pop noise of dmic recording in kabylake platform using rt5514

[Vinod Koul <vinod.koul@intel.com>]

On Wed, Jul 26, 2017 at 01:47:44PM -0700, Harsha Priya wrote:
> This patch fixes the pop noise in dmic recording using rt5514 on kabylake platform.
> This patch enables the rt5514 to use MCLK instead of BLCK as the sysclock which fixes
> the pop noise.

Please consider changing patch title to document the change you did so:

"ASoC: Intel: use MCLK instead of BLCK as the sysclock"

describes this patch rather than current one..

> 
> Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
> ---
>  sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> index cfde894..cfd89ca 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> @@ -351,19 +351,10 @@ static int kabylake_ssp0_hw_params(struct snd_pcm_substream *substream,
>  				return ret;
>  			}
>  
> -			ret = snd_soc_dai_set_pll(codec_dai, 0,
> -				RT5514_PLL1_S_BCLK, RT5514_AIF1_BCLK_FREQ,
> -						RT5514_AIF1_SYSCLK_FREQ);
> -			if (ret < 0) {
> -				dev_err(rtd->dev, "set bclk err: %d\n", ret);
> -				return ret;
> -			}
> -
>  			ret = snd_soc_dai_set_sysclk(codec_dai,
> -				RT5514_SCLK_S_PLL1, RT5514_AIF1_SYSCLK_FREQ,
> -							SND_SOC_CLOCK_IN);
> +				RT5514_SCLK_S_MCLK, 24576000, SND_SOC_CLOCK_IN);
>  			if (ret < 0) {
> -				dev_err(rtd->dev, "set sclk err: %d\n", ret);
> +				dev_err(rtd->dev, "set sysclk err: %d\n", ret);
>  				return ret;
>  			}
>  		}
> -- 
> 1.9.1
> 

-- 
~Vinod